Fix sign in redirect when token is expired #1510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix opencollective/opencollective#1797
In #1434 I made some changes to properly redirect a user that would click on a signin link with an invalid token while already being logged in.
However I made a false assumption while working on it as I considered that an invalid token was the same things that an expired token.
As a consequence, the bug would still appear for a user that would click on an old sign in link.
Changes
/signin/{token}?next=/
, if token is expired, we still try to login with thelocalStorage
tokenassertLoggedIn
helper for tests