Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Test Cases for Create, Remove api Objects #94

Merged

Conversation

selldinesh
Copy link
Contributor

@selldinesh selldinesh commented Apr 27, 2023

Description of PR

Summary: Contributing SAI test cases that qualifies the SAI apis. This PR consists of test cases that does create and remove operation on the API.
The cases have been validated to be passing on:

Sonic Version: SONiC.master.182904-b774ebfdc,
HwSKU: Accton-AS7726-32X
ASIC: broadcom
SAI-Challenger Version: 2241a1a

@andriy-kokhan
Copy link
Contributor

@selldinesh , thank you for the contribution!
Please make sure all commits are signed off. For more details, please refer to https://github.com/opencomputeproject/SAI-Challenger/blob/main/CONTRIBUTING.md

@andriy-kokhan
Copy link
Contributor

Please include these TCs into CI/CD for a standalone workflow https://github.com/opencomputeproject/SAI-Challenger/blob/main/.github/workflows/sc-docker-standalone-bldr.yml
E.g., to add for Redis API:

    - name: Run API tests
      run: ./exec.sh --no-tty pytest --testbed=saivs_standalone -v -k "api/test"

@selldinesh selldinesh changed the title adding create remove api testcases Adding Test Cases for Create, Remove api Objects Apr 28, 2023
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
@andriy-kokhan
Copy link
Contributor

Please include these TCs into CI/CD for a standalone workflow https://github.com/opencomputeproject/SAI-Challenger/blob/main/.github/workflows/sc-docker-standalone-bldr.yml E.g., to add for Redis API:

    - name: Run API tests
      run: ./exec.sh --no-tty pytest --testbed=saivs_standalone -v -k "api/test"

@selldinesh , please include these TCs into GitHub workflow. Ideally, they should be validated for both Redis and Thrift RPC. Thanks

@andriy-kokhan andriy-kokhan merged commit 53b32cc into opencomputeproject:main Jul 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants