[meta] Add enum ancestry check on SAI includes #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipankar-ba
pushed a commit
to dipankar-ba/SAI
that referenced
this pull request
Sep 13, 2021
This check will make sure that enum values are constant from this point on all future commits. [meta] Add enum ancestry check on SAI includes (opencomputeproject#1297) Will make sure that from BEGIN_COMMIT we will be always backward compatible for SAI enums Class-Based Forwarding (opencomputeproject#1193) This PR defines class-based forwarding. It contains two aspects: Assignment of a Forwarding Class to a packet, via QOS map or ACL New next-hop group type: SAI_NEXT_HOP_GROUP_TYPE_CLASS_BASED Where member selection is based on the forwarding-class of the packet. Signed-off-by: Jason Bos <jbos@cisco.com> [tests] Add missing lib -lzmq to saithrift (opencomputeproject#1298) [meta] Make sure SAI version components are unsigned integers (opencomputeproject#1300) [meta] Add lower case notification names (opencomputeproject#1301)
kcudnik
added a commit
to kcudnik/sonic-sairedis
that referenced
this pull request
May 19, 2023
since commit 8e1fb37 (v1.8.0) there is check enum binary backward compatibility so we are relaxing this check below, versions do not have to be equal but both need to be at least 2ebde24 (v1.9.0), this will make sure that enums are always ok, but since that commit some data structures changed and are not binary backwad compatible like next hop group api, acl_capability, structs are backward binary compatible from commit aed34c8, which closest tag version for it is commit 3ff228a (v1.12.0), so min version check should be set to (v1.12.0), but some production branches do not use that high SAI version yet, some use even version v1.7.0 which then it is impossible to provide even enum backward compatibility, check those links: opencomputeproject/SAI#1297 (enums) opencomputeproject/SAI#1795 (structs)
StormLiangMS
pushed a commit
to sonic-net/sonic-sairedis
that referenced
this pull request
May 20, 2023
* [configure] Check for minimal SAI version since commit 8e1fb37 (v1.8.0) there is check enum binary backward compatibility so we are relaxing this check below, versions do not have to be equal but both need to be at least 2ebde24 (v1.9.0), this will make sure that enums are always ok, but since that commit some data structures changed and are not binary backwad compatible like next hop group api, acl_capability, structs are backward binary compatible from commit aed34c8, which closest tag version for it is commit 3ff228a (v1.12.0), so min version check should be set to (v1.12.0), but some production branches do not use that high SAI version yet, some use even version v1.7.0 which then it is impossible to provide even enum backward compatibility, check those links: opencomputeproject/SAI#1297 (enums) opencomputeproject/SAI#1795 (structs) * Fix condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will make sure that from BEGIN_COMMIT we will be always backward compatible