[SAI-PTFv2] Skip brcm teardown assertion #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyoYang
force-pushed
the
skip_brcm_teardown_assert
branch
from
7644506
to
b4e09cf
Compare
richardyu-ms
approved these changes
Mar 1, 2022
|
could you help add some log messages with what's the data that cannot pass the validation after we clear/reset the environment in the teardown? |
Signed-off-by: Yang Wang <yangwang1@microsoft.com>
RyoYang
force-pushed
the
skip_brcm_teardown_assert
branch
from
b4e09cf
to
dc7504f
Compare
RyoYang
added a commit
to RyoYang/SAI
that referenced
this pull request
Mar 3, 2022
Signed-off-by: Yang Wang <yangwang1@microsoft.com>
richardyu-ms
pushed a commit
that referenced
this pull request
Mar 3, 2022
RyoYang
added a commit
to RyoYang/SAI
that referenced
this pull request
Mar 14, 2022
…oject#1428) Signed-off-by: Yang Wang <yangwang1@microsoft.com>
RyoYang
added a commit
to RyoYang/SAI
that referenced
this pull request
Mar 14, 2022
…oject#1428) Signed-off-by: Yang Wang <yangwang1@microsoft.com>
richardyu-ms
added a commit
that referenced
this pull request
Mar 14, 2022
* SAI PTF 1: Proposal (#1325) This is an autogeneration framework for PTF based SAI tests. Before in order to add a new test it is necessary to: 1. Add an entry in switch_sai.thrift. 2. Add RPC server method for new entry in switch_sai_rpc_server.cpp. 3. Add a python wrapper in switch.py (if applicable). 4. Write a new test The main goal of autogeneration framework is to generate first three steps based on SAI headers to facilitate the process of writing new tests. * Create SAI-Proposal-SAI_PTF.md * Adding generator script * New makefile target and cleanup Signed-off-by: Yang Wang <yangwang1@microsoft.com> * SAI PTF 2: sai_base_test infra (#1335) The changes introduce SAI PTF framework base tests infrastructure. Following files have been added: sai_rpc_frontend.cpp - RPC server frontend file - there is a set of manually written helper functions that converts/parses SAI and thrift attributes and also here we have autogenerated SAI RPC server functions included sai_base_test.py - python module with base test classes with common tests configuration sai_utils.py - python module with some helper function used in SAI PTF tests saitest.py - first test module with simple framework test Signed-off-by: Aleksandra Jereczek <aleksandra.jereczek@intel.com> Signed-off-by: Yang Wang <yangwang1@microsoft.com> * Proposal for init switch and destroy switch from PRC (#1387) keep the switch id in creat_switch and remove it from remove_switch 1. support to create the create_switch only once before the test run and use the same switch id within multi-round of testing 2. support remove the switch id Signed-off-by: Richard Yu <richard.yu@microsoft.com> Signed-off-by: Yang Wang <yangwang1@microsoft.com> * [SAIServer]Add new SaiServer to support ptf-SAI test structure (#1388) * [SAIServer]Add new SaiServer to support ptf-SAI test structure Add build script to generate the necessary package as saiserverv2 Add new saiserver to support new structure - without switch init and with thrift 0.13.0 Add makefile add sai_rpc_frontend simplify saiserver and remove init method add permission for copy_saithriftv2.s copy saiserver at dh builddeb ctypesgen for sai-ptf and install python-saithrift for two version Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add a package name for sai_adapter Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * address review comments Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * add more comments for the command in the Makefile Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Yang Wang <yangwang1@microsoft.com> * Add platform support and a sanity test sample (#1390) (#1415) * Add a middle layer (strategy and factory) under the test cases which can no more if-else for platform selecting no more code injection for different platforms, just need to abstract to a method on the differences auto select the platform by the parameters in the test starter (shell, happed in run_p4_tests, not published here) easy-distinct structure for the difference from platforms prepared for future statistic Add a sanity sample, it can configure across all the ports (base on port's configuration file) simple FDB and VLAN naming according to port's number make a basic check on the status of the devices use as a sample for how to use the new middle layer fix and suppress LGTM alters Signed-off-by: Richard Yu <richard.yu@microsoft.com> * code refactor part I - add comments for class and method - reformat code - move platform related method to corresponding class code refactor Part II optimize the class hirerarchy simplify the import items add more docs Signed-off-by: richardyu-ms <richard.yu@microsoft.com> * suppress lgtm warnings fix lgtm warning Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Yang Wang <yangwang1@microsoft.com> * [FIX]Fix the circular reference issue when build sai header py (#1427) Fix circular reference issue. Test done: build the saiserver and check the sai_headers.py Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Yang Wang <yangwang1@microsoft.com> * Skip brcm teardown assertion (#1423) (#1428) Signed-off-by: Yang Wang <yangwang1@microsoft.com> * Add two more API as RPC for warmboot testing (#1421) (#1437) try to expose the sai api object_type_query and switch_id_query for warmboot testing Modify the template file for generate code from meta. Signed-off-by: richardyu-ms <richard.yu@microsoft.com> Signed-off-by: Yang Wang <yangwang1@microsoft.com> Co-authored-by: Patrycja Kochmanska <patrycja.kochmanska@intel.com> Co-authored-by: Aleksandra Jereczek <aleksandra.jereczek@intel.com> Co-authored-by: Richard.Yu <richard.yu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip sai_base_helper teardown assertion due to known brcm's remove_switch issue shown as below:
Test done:
Tested on dut device.