Update Copyrights #52
Conversation
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
LICENSE
Outdated
| @@ -176,6 +176,7 @@ | |||
|
|
|||
| END OF TERMS AND CONDITIONS | |||
|
|
|||
| Copyright 2019, 2020 The Linux Foundation | |||
There was a problem hiding this comment.
Looking at the list of recommended options
Perhaps "Copyright 2019, 2020 The go-digest contributors" (or "authors") ?
(I personally like "authors" or "contributors", as it more clearly describes that copyright is not transferred to <some organisation>, but remains with the author/contributor)
|
I agree. This is mirroring the copyright in the other OCI specs. I'm not sure of the reason for the attribution to be to Linux Foundation, rather than contributors or members or such.
…-------- Original Message --------
On Jan 10, 2020, 04:47, Sebastiaan van Stijn wrote:
@thaJeztah commented on this pull request.
---------------------------------------------------------------
In [LICENSE](#52 (comment)):
> @@ -176,6 +176,7 @@
END OF TERMS AND CONDITIONS
+ Copyright 2019, 2020 The Linux Foundation
Looking at the list of [recommended options](https://github.com/cncf/foundation/blob/master/copyright-notices.md#copyright-notices)
Perhaps "Copyright 2019, 2020 The go-digest contributors" ?
(I personally like "authors" or "contributors", as it more clearly describes that copyright is not transferred to <some organisation>, but remains with the author/contributor)
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#52?email_source=notifications&email_token=AAAQL2LU2XQVMNGNL6YFLXTQ5A72XA5CNFSM4KE55QJKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRKA2MQ#pullrequestreview-341052722), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAAQL2OIHG2G3O7KDIEQOQDQ5A72XANCNFSM4KE55QJA).
|
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
|
updated to copyright by "OCI Contributors" |
|
come on @opencontainers/go-digest-maintainers ... |
|
(i'm wanting to cut a 1.0.0 release #46) |
|
LGTM |
|
LGTM |
|
not sure why Stephen's LGTM didn't work? It was "Lgtm" to begin with, and didn't trigger the pullapprove. I edited to be "LGTM", but that also hasn't triggered.. |
|
LGTM |
|
There is another PR to fix pull approve, but also pull approve doesn't work on that PR 🤦♂️ |
|
merge? |
|
@caniszczyk help? |
|
ping @caniszczyk 🙏 |
|
LGTM (for old times sake) |
|
LGTM sorry, too many github notifications, message me next time :) but yes, this falls in lines with LF guidelines |
No description provided.