Update Go to 1.19 and bump dependencies #1084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
requested review from
jonjohnsonjr,
jonboulle,
stevvooe,
sajayantony,
tianon,
vbatts and
cyphar
as code owners
tianon
reviewed
Jun 29, 2023
| @@ -1,6 +1,6 @@ | |||
| module github.com/opencontainers/image-spec | |||
|
|
|||
| go 1.18 | |||
| go 1.19 | |||
There was a problem hiding this comment.
Given that this is now officially defined as the lowest version supported by the module (not the recommended/preferred version, as it's been previously), should we try to be more conservative than what Go officially supports in case we've got some lagging consumers?
We don't have a lot of Go code in here, and I don't think there have been any really compelling Go features/changes for the functionality we actually use, so I guess this is functionally going to be dictated by our few dependencies more than it is by our own code. 🤔
There was a problem hiding this comment.
That's fair. I also noticed that our GHA has 3 versions being tested (1.18, 1.19, and 1.20) so this update can wait until 1.21 comes out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.19 and 1.20 are the current supported releases. This bumps to the oldest supported release.