Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementations: add a list of known implementations #602

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Mar 9, 2017

Fixes #126
Fixes #396

Signed-off-by: Vincent Batts vbatts@hashbangbash.com

@vbatts vbatts force-pushed the implementations branch 2 times, most recently from 666d442 to 7502adb Compare March 9, 2017 16:48
@@ -0,0 +1,18 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this newline necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noup

- [containers/build](https://github.com/containers/build)
- [containers/image](https://github.com/containers/image)
* [coreos/rkt](https://github.com/coreos/rkt)
* [erikh/box](https://github.com/erikh/box)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a suggestion for people to add their implementations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, fair

@jonboulle
Copy link
Contributor

thanks for doing this

@vbatts
Copy link
Member Author

vbatts commented Mar 9, 2017

updated. PTAL

@jonboulle
Copy link
Contributor

seems reasonable

@jonboulle
Copy link
Contributor

jonboulle commented Mar 9, 2017

LGTM, obviously the idea this is a living document, so we can keep an eye on keeping it up to date as the ecosystem evolves.

Approved with PullApprove

* [openSUSE/umoci](https://github.com/openSUSE/umoci)
* [cloudfoundry/grootfs](https://github.com/cloudfoundry/grootfs) ([source](https://github.com/cloudfoundry/grootfs/blob/c3da26e1e463b51be1add289032f3dca6698b335/fetcher/remote/docker_src.go))
* [Mesos plans](https://issues.apache.org/jira/browse/MESOS-5011) ([design doc](https://docs.google.com/document/d/1Pus7D-inIBoLSIPyu3rl_apxvUhtp3rp0_b0Ttr2Xww/edit#heading=h.hrvk2wboog4p))
* [Docker](https://github.com/docker)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget containerd!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right. I knew the that image-spec support was on the horizon, but didn't think it was a PR yet. Should've looked

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Fixes opencontainers#126

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@stevvooe
Copy link
Contributor

stevvooe commented Mar 9, 2017

LGTM

Approved with PullApprove

@jonboulle
Copy link
Contributor

jonboulle commented Mar 9, 2017

lgtm

Approved with PullApprove

@jonboulle jonboulle merged commit 37f2a1b into opencontainers:master Mar 9, 2017
@vbatts vbatts mentioned this pull request May 19, 2017
@vbatts vbatts deleted the implementations branch July 19, 2017 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants