Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOVERNANCE: Proposing a motion is a LGTM by default #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wking
Copy link
Contributor

@wking wking commented Sep 8, 2016

To avoid uncertainty like this.

This is more than a typo-fix, so it probably deserves an
all-maintainers vote to confirm the change. I'm going to remove the
co-sponsor requirement in a separate PR, and we can batch those two
together for a single vote if that would make life easier for
maintainers.

@vbatts
Copy link
Member

vbatts commented Sep 8, 2016

LGTM

Approved with PullApprove

@vbatts
Copy link
Member

vbatts commented Sep 8, 2016

actually no, that is like LGTM'ing your own PR, which we disallow.
Rejected

Rejected with PullApprove

@wking
Copy link
Contributor Author

wking commented Sep 8, 2016

On Thu, Sep 08, 2016 at 11:33:06AM -0700, Vincent Batts wrote:

actually no, that is like LGTM'ing your own PR, which we disallow.
Rejected

We have a much more relaxed quorum requirement for PRs (2 LGTMs, vs. ⅔
for voted proposals). And the motivation for blocking self-LGTMs is
1:

to ensure equal amounts of review for every pull request, no matter
who wrote it

Non-maintainers may submit pull requests (and need two other folks to
LGTM it), so that's consistent. But non-maintainers cannot propose
motions, so every proposal is reviewed equally even if you allow
sponsor votes.

If, I cannot convince folks that sponsor(s) should be allowed to vote,
my next proposal would be to remove them from the quorum count. With
wording like:

A quorum is established when at least two-thirds of non-sponsor
maintainers have voted.

but ick ;).

If we block sponsor votes but keep them in the quorum, I think we'll
be raising our quorum requirement too high. It's a shame when a vote
fails because folks didn't notice it 2.

@tianon
Copy link
Member

tianon commented Sep 8, 2016

As I mentioned on the list, I'd rather the proposer's acceptance be implied unless they state otherwise. If they don't agree with the proposal, it seems silly IMO for them to be proposing it.

(Not sure if my vote counts here, but just in case:)
Rejected

@wking
Copy link
Contributor Author

wking commented Sep 8, 2016

On Thu, Sep 08, 2016 at 12:17:09PM -0700, Tianon Gravi wrote:

As I mentioned on the list, I'd rather the proposer's acceptance be
implied unless they state otherwise. If they don't agree with the
proposal, it seems silly IMO for them to be proposing it.

You don't buy my “reject a proposal they consider crazy” workflow 1?
;). I think it's easy to stick a LGTM in your propsal, so I like
ca46aab as it stands. But if that seems like too high a bar, I'm ok
with language like:

Unless the sponsor(s) explicitly LGTM/REJECT the proposal, the
submitting the proposal counts as a LGTM.

Both that wording and ca46aab allow sponsor(s) to vote, which
@vbatts is concerned about 2 but I think is appropriate 3. Do you
have any problems with sponsor(s) voting in general?

(Not sure if my vote counts here, but just in case:)
Rejected

I'm not sure how pull-approve is setup for this site, but my
understanding is that the maintainers are the union of all OCI project
maintainers (in which case your vote counts).

 Subject: Re: [runtime-spec VOTE]: Tag d3c3763b as v1.0.0-rc2 (closes
  2016-09-08 13:47 UTC)
 Date: Thu, 8 Sep 2016 11:08:16 -0700
 Message-ID: <20160908180816.GZ14866@odin.tremily.us>

@tianon
Copy link
Member

tianon commented Sep 8, 2016

Yeah, I don't have any problem with the proposer voting -- I think your reasoning makes sense regarding that, I just think that the situations in which someone would propose something they actually disagree with are small enough that it's worth optimizing our already high-overhead process for the default common case (which is that the proposer agrees with what they're proposing).

wking added a commit to wking/oci-project-template that referenced this pull request Sep 8, 2016
To avoid uncertainty like [1].  I think an explicit LGTM is easy to
add [2], but Tianon points out that there's already a lot to remember
when proposing a vote, and most of the time the sponsor(s) will be in
favor of the motion they're proposing [3].

[1]: https://groups.google.com/a/opencontainers.org/d/msg/dev/5qj2hATVxew/-ljDGQB0AQAJ
     Subject: Re: [runtime-spec VOTE]: Tag d3c3763b as v1.0.0-rc2 (closes
       2016-09-08 13:47 UTC)
     Date: Thu, 8 Sep 2016 13:48:38 -0400
     Message-ID: <CANcsyS6q5neOqT+MLxhFDvDKPLGaYpY=HKy0p4pMjs3zexQs_A@mail.gmail.com>
[2]: https://groups.google.com/a/opencontainers.org/d/msg/dev/5qj2hATVxew/yu0x3ix1AQAJ
     Subject: Re: [runtime-spec VOTE]: Tag d3c3763b as v1.0.0-rc2 (closes
       2016-09-08 13:47 UTC)
     Date: Thu, 8 Sep 2016 11:08:16 -0700
     Message-ID: <20160908180816.GZ14866@odin.tremily.us>
[3]: opencontainers#18 (comment)
     Subject: GOVERNANCE: Require explicit sponsor votes

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking wking changed the title GOVERNANCE: Require explicit sponsor votes GOVERNANCE: Proposing a motion is a LGTM by default Sep 8, 2016
@wking
Copy link
Contributor Author

wking commented Sep 8, 2016

On Thu, Sep 08, 2016 at 12:33:31PM -0700, Tianon Gravi wrote:

… I just think that the situations in which someone would propose
something they actually disagree with are small enough that it's
worth optimizing our already high-overhead process for the default
common case (which is that the proposer agrees with what they're
proposing).

Maybe I've just absorbed too much “Explicit is better than implicit”
1 ;). Anyhow, updated to make proposing a motion an explicit LGTM
with ca46aab30f6050.

@tianon
Copy link
Member

tianon commented Sep 8, 2016

Heh, I generally agree, but in this case, I'm more partial to "Simple is better than complex."

30f6050 LGTM 👍

@vbatts
Copy link
Member

vbatts commented Sep 8, 2016

Might as well say "unless sponsor explicitly REJECT" rather than or LGTM,
but it doesn't break any logic being this way.

30f6050 LGTM

On Thu, Sep 8, 2016, 15:51 Tianon Gravi notifications@github.com wrote:

Heh, I generally agree, but in this case, I'm more partial to "Simple is
better than complex."

30f6050
30f6050
LGTM 👍


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#18 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEF6YWVFeYt92E_6UKLIPnM81Yad32qks5qoGdYgaJpZM4J4Sms
.

To avoid uncertainty like [1].  I think an explicit LGTM is easy to
add [2], but Tianon points out that there's already a lot to remember
when proposing a vote, and most of the time the sponsor(s) will be in
favor of the motion they're proposing [3].

[1]: https://groups.google.com/a/opencontainers.org/d/msg/dev/5qj2hATVxew/-ljDGQB0AQAJ
     Subject: Re: [runtime-spec VOTE]: Tag d3c3763b as v1.0.0-rc2 (closes
       2016-09-08 13:47 UTC)
     Date: Thu, 8 Sep 2016 13:48:38 -0400
     Message-ID: <CANcsyS6q5neOqT+MLxhFDvDKPLGaYpY=HKy0p4pMjs3zexQs_A@mail.gmail.com>
[2]: https://groups.google.com/a/opencontainers.org/d/msg/dev/5qj2hATVxew/yu0x3ix1AQAJ
     Subject: Re: [runtime-spec VOTE]: Tag d3c3763b as v1.0.0-rc2 (closes
       2016-09-08 13:47 UTC)
     Date: Thu, 8 Sep 2016 11:08:16 -0700
     Message-ID: <20160908180816.GZ14866@odin.tremily.us>
[3]: opencontainers#18 (comment)
     Subject: GOVERNANCE: Require explicit sponsor votes

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking
Copy link
Contributor Author

wking commented Sep 8, 2016

On Thu, Sep 08, 2016 at 12:59:48PM -0700, Vincent Batts wrote:

Might as well say "unless sponsor explicitly REJECT" rather than or LGTM,
but it doesn't break any logic being this way.

Good point. Replaced “LGTM or REJECT” with “REJECT or ABSTAIN” in
30f6050ee50249.

@tianon
Copy link
Member

tianon commented Sep 8, 2016

ee50249 LGTM

@vbatts
Copy link
Member

vbatts commented Sep 8, 2016

ee50249 LGTM

On Thu, Sep 8, 2016, 16:10 Tianon Gravi notifications@github.com wrote:

ee50249
ee50249
LGTM


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#18 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEF6Rrb8_DyFvWtM5FqgxC_3AwkRvT6ks5qoGuhgaJpZM4J4Sms
.

@hqhq
Copy link

hqhq commented Sep 9, 2016

LGTM

Approved with PullApprove

wking added a commit to wking/ocitools-v2 that referenced this pull request Nov 17, 2016
…late into merge-project-template

To fulfill the TOB's [1]:

  Both of the proposed projects would incorporate the Governance and
  Releases processes from the OCI project template:
  https://github.com/opencontainers/project-template.

which was approved with this vote [2].

Generated with:

  $ git pull git://github.com/opencontainers/project-template.git master
  $ git checkout --ours .pullapprove.yml README.md
  $ git checkout --theirs CONTRIBUTING.md LICENSE MAINTAINERS_GUIDE.md
  $ git add .pullapprove.yml CONTRIBUTING.md LICENSE MAINTAINERS_GUIDE.md README.md
  $ git commit

I think there are a few improvements we could make to these template
docs [3,4,5], but the TOB vote happened before I'd floated those.
If/when they land, we can pull the updated versions into this
repository via a follow-up merge.

* 'master' of git://github.com/opencontainers/project-template: (33 commits)
  .pullapprove.yml: Reset on push, ignore authors, and require sign-offs
  GOVERNANCE.md: fix typo
  GOVERNANCE and RELEASES: split the files
  project-governance: Make voting more generic
  proposals: release approval process explain security@ email
  proposal: fix a typo
  proposals: release-approval-process fix a grammar thing
  release-approval: Add non-spec unanimous quorum reduction
  release-approval: Shuffle to make more DRY
  proposals: release-approval-process: fixup additional typos
  proposals: release approval process: improve REJECT feedback
  proposals: release approval process: add information to projects
  proposals: release approval process: add language about mailing list
  proposals: release approval process: add quorum language
  proposals: release-approval-process: add voting members language
  proposals: release approval process: clarify utility of GitHub
  proposals: release approval process: use consistent language for rejects
  proposals: release approval process: one month pre-releases
  proposals: release approval process 3 rcs required
  proposals: release approval process to one week for apps
  ...

Conflicts:
	.pullapprove.yml
	CONTRIBUTING.md
	LICENSE
	MAINTAINERS_GUIDE.md
	README.md

[1]: https://github.com/opencontainers/tob/blob/8997b1aa221b3b61d4305bede41c257b879bdeeb/proposals/tools.md#governance-and-releases
[2]: https://groups.google.com/a/opencontainers.org/forum/#!topic/tob/rZ4luMa-pxY
     Subject: VOTE Required: approve new projects: image-tools, runtime-tools
     Date: Wed, 07 Sep 2016 22:37:32 +0000
     Message-ID: <CAD2oYtMLMFQouEVU7HTO-EKnW6vKu82dGT+0mziXZzCyqngj=A@mail.gmail.com>
[3]: opencontainers/project-template#18
     Subject: GOVERNANCE: Proposing a motion is a LGTM by default
[4]: opencontainers/project-template#19
     Subject: GOVERNANCE: Drop the co-sponsor requirement
[5]: opencontainers/project-template#20
     Subject: MAINTAINERS_GUIDE|CONTRIBUTING: Make generic enough for all OCI Projects
wking added a commit to wking/ocitools-v2 that referenced this pull request Nov 17, 2016
…late into merge-project-template

To fulfill the TOB's [1]:

  Both of the proposed projects would incorporate the Governance and
  Releases processes from the OCI project template:
  https://github.com/opencontainers/project-template.

which was approved with this vote [2].

Generated with:

  $ git pull git://github.com/opencontainers/project-template.git master
  $ git checkout --ours .pullapprove.yml README.md
  $ git checkout --theirs CONTRIBUTING.md LICENSE MAINTAINERS_GUIDE.md
  $ git add .pullapprove.yml CONTRIBUTING.md LICENSE MAINTAINERS_GUIDE.md README.md
  $ git commit

I think there are a few improvements we could make to these template
docs [3,4,5], but the TOB vote happened before I'd floated those.
If/when they land, we can pull the updated versions into this
repository via a follow-up merge.

* 'master' of git://github.com/opencontainers/project-template: (33 commits)
  .pullapprove.yml: Reset on push, ignore authors, and require sign-offs
  GOVERNANCE.md: fix typo
  GOVERNANCE and RELEASES: split the files
  project-governance: Make voting more generic
  proposals: release approval process explain security@ email
  proposal: fix a typo
  proposals: release-approval-process fix a grammar thing
  release-approval: Add non-spec unanimous quorum reduction
  release-approval: Shuffle to make more DRY
  proposals: release-approval-process: fixup additional typos
  proposals: release approval process: improve REJECT feedback
  proposals: release approval process: add information to projects
  proposals: release approval process: add language about mailing list
  proposals: release approval process: add quorum language
  proposals: release-approval-process: add voting members language
  proposals: release approval process: clarify utility of GitHub
  proposals: release approval process: use consistent language for rejects
  proposals: release approval process: one month pre-releases
  proposals: release approval process 3 rcs required
  proposals: release approval process to one week for apps
  ...

Conflicts:
	.pullapprove.yml
	CONTRIBUTING.md
	LICENSE
	MAINTAINERS_GUIDE.md
	README.md

[1]: https://github.com/opencontainers/tob/blob/8997b1aa221b3b61d4305bede41c257b879bdeeb/proposals/tools.md#governance-and-releases
[2]: https://groups.google.com/a/opencontainers.org/forum/#!topic/tob/rZ4luMa-pxY
     Subject: VOTE Required: approve new projects: image-tools, runtime-tools
     Date: Wed, 07 Sep 2016 22:37:32 +0000
     Message-ID: <CAD2oYtMLMFQouEVU7HTO-EKnW6vKu82dGT+0mziXZzCyqngj=A@mail.gmail.com>
[3]: opencontainers/project-template#18
     Subject: GOVERNANCE: Proposing a motion is a LGTM by default
[4]: opencontainers/project-template#19
     Subject: GOVERNANCE: Drop the co-sponsor requirement
[5]: opencontainers/project-template#20
     Subject: MAINTAINERS_GUIDE|CONTRIBUTING: Make generic enough for all OCI Projects

Signed-off-by: W. Trevor King <wking@tremily.us>
wking added a commit to wking/oci-project-template that referenced this pull request Dec 1, 2016
Catching up with opencontainers/tob@729e1ecf (Merge pull request opencontainers#18
from RobDolinMS/master, 2016-09-18).  I'd rather drop the
parenthetical entirely and link to a place that listed OCI Projects,
but we don't have a canonical target for that yet
(opencontainers/tob#2) and the current closest instance seems to be
the GitHub section in [1] (which doesn't have the "OCI Project"
words).

[1]: https://www.opencontainers.org/community

Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants