Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.pullapprove.yml: Add distribution-spec-maintainers #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wking
Copy link
Contributor

@wking wking commented Apr 4, 2018

Catching up with opencontainers/tob#35.

We'll want this if we're trying to continue with the “two maintainers from every OCI Project have LGTMed” approach initially adopted in f412693 (#29). See #41 for some other maintenance ideas; but as long as that's open I think we need to continue with the current pattern.

Catching up with [1].

Also mention the new project in GOVERNANCE.md.  I'd still rather drop
the parenthetical entirely and link to a place that listed OCI
Projects, but we don't have a canonical target for that yet
(opencontainers/tob#2) and the current closest instance seems to be
the GitHub section in [2] (which doesn't have the "OCI Project"
words).

[1]: opencontainers/tob#35
[2]: https://www.opencontainers.org/community

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking
Copy link
Contributor Author

wking commented Apr 6, 2018

I've just squashed in an update to the GOVERNANCE.md OCI Project list. I still wish we could replace that inline list with a link to an external list (as I've mentioned before ;), but with opencontainers/tob#2 still open there's still no good link target.

@wking
Copy link
Contributor Author

wking commented Apr 6, 2018

The PullApprove failure is:

['distribution-spec-maintainers'] is an invalid value for teams: distribution-spec-maintainers team not found on this repo

We've had similar issues before. Perhaps @caniszczyk remembers the appropriate way to kick PullApprove?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant