Give summary when failed to pause containers

When we failed to pause one or more containers, besides the error
message for each container, we should give a more useful summary
information e.g. "failed to pause containers: ctrA,ctrB", instead of
"one or more of the container deletions failed", the old summary info is
totally useless.

Signed-off-by: Zhang Wei <zhangwei555@huawei.com>

pause.go

@@ -5,6 +5,7 @@ package main
 import (
 	"fmt"
 	"os"
+	"strings"
 
 	"github.com/urfave/cli"
 )
@@ -20,7 +21,7 @@ paused. `,
 
 Use runc list to identiy instances of containers and their current status.`,
 	Action: func(context *cli.Context) error {
-		hasError := false
+		var failedOnes []string
 		if !context.Args().Present() {
 			return fmt.Errorf("runc: \"pause\" requires a minimum of 1 argument")
 		}
@@ -34,17 +35,17 @@ Use runc list to identiy instances of containers and their current status.`,
 			container, err := factory.Load(id)
 			if err != nil {
 				fmt.Fprintf(os.Stderr, "container %s does not exist\n", id)
-				hasError = true
+				failedOnes = append(failedOnes, id)
 				continue
 			}
 			if err := container.Pause(); err != nil {
 				fmt.Fprintf(os.Stderr, "pause container %s : %s\n", id, err)
-				hasError = true
+				failedOnes = append(failedOnes, id)
 			}
 		}
 
-		if hasError {
-			return fmt.Errorf("one or more of container pause failed")
+		if len(failedOnes) > 0 {
+			return fmt.Errorf("failed to pause containers: %s", strings.Join(failedOnes, ","))
 		}
 		return nil
 	},

tests/integration/pause.bats

@@ -85,9 +85,10 @@ function teardown() {
 
   wait_for_container 15 1 test_busybox2
 
-  # pause test_busybox1, test_busybox2 and nonexistant container
-  runc pause test_busybox1 test_busybox2 nonexistant
+  # pause test_busybox1, test_busybox2 and nonexistent container
+  runc pause test_busybox1 test_busybox2 nonexistent
   [ "$status" -ne 0 ]
+  [[ ${lines[-1]} =~ "failed to pause containers: nonexistent ]]
 
   # test state of test_busybox1 and test_busybox2 is paused
   testcontainer test_busybox1 paused