Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build of the SELinux API for unsupported platforms #102

Closed
pmorie opened this issue Jul 8, 2015 · 5 comments
Closed

Add a build of the SELinux API for unsupported platforms #102

pmorie opened this issue Jul 8, 2015 · 5 comments

Comments

@pmorie
Copy link
Contributor

pmorie commented Jul 8, 2015

Currently, in projects that consume the SELinux api from libcontainer, you need to differentiate files for builds for linux and other platforms. It might be really convenient to have an implementation of SelinuxEnabled for non-supported platforms. Thoughts? @mrunalp @crosbymichael @rhatdan @vbatts

@pmorie
Copy link
Contributor Author

pmorie commented Jul 8, 2015

For the record, I don't expect this will solve having to differentiate files for selinux specific code. The exact situation that I ran into is that I'm writing some unit tests that do not test selinux directly (and so do not use the selinux API), but that should be skipped when SELinux is disabled. I wound up making a package-level func for this right now that I call from the tests.

@rhatdan
Copy link
Contributor

rhatdan commented Jul 8, 2015

Maybe add label.Enabled()?

@crosbymichael
Copy link
Member

You could just check in the tests and skip the test if selinux is not enabled.

@crosbymichael
Copy link
Member

Is this still needed?

@pmorie
Copy link
Contributor Author

pmorie commented Feb 10, 2016

For my use-case personally in kubernetes we just use build flags, this can be closed IMO

@pmorie pmorie closed this as completed Feb 10, 2016
stefanberger pushed a commit to stefanberger/runc that referenced this issue Sep 8, 2017
README: Document pre-meeting agenda alteration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants