-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a build of the SELinux API for unsupported platforms #102
Comments
For the record, I don't expect this will solve having to differentiate files for selinux specific code. The exact situation that I ran into is that I'm writing some unit tests that do not test selinux directly (and so do not use the selinux API), but that should be skipped when SELinux is disabled. I wound up making a package-level func for this right now that I call from the tests. |
Maybe add label.Enabled()? |
You could just check in the tests and skip the test if selinux is not enabled. |
Is this still needed? |
For my use-case personally in kubernetes we just use build flags, this can be closed IMO |
README: Document pre-meeting agenda alteration
Currently, in projects that consume the SELinux api from libcontainer, you need to differentiate files for builds for linux and other platforms. It might be really convenient to have an implementation of
SelinuxEnabled
for non-supported platforms. Thoughts? @mrunalp @crosbymichael @rhatdan @vbattsThe text was updated successfully, but these errors were encountered: