Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chroot() function appears to ignore its parameter #2214

Open
setharnold opened this issue Jan 16, 2020 · 3 comments
Open

chroot() function appears to ignore its parameter #2214

setharnold opened this issue Jan 16, 2020 · 3 comments

Comments

@setharnold
Copy link

Hello, this chroot() wrapper appears to ignore the rootfs parameter. Is this an accidental oversight?

func chroot(rootfs string) error {

Thanks

@cyphar
Copy link
Member

cyphar commented Jan 16, 2020

This is an oversight, but it works okay because we Chdir(rootfs) earlier during setup.

@setharnold
Copy link
Author

Thanks cyphar; I'm glad to hear it's not a huge concern.

Thanks

@cyphar
Copy link
Member

cyphar commented Jan 17, 2020

Feel free to send a patch which either uses the path or removes the parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants