Chroot rootfs path usage fix #2237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cyphar PTAL |
Zyqsempai
force-pushed
the
2214-chroot-path-usage-fix
branch
from
5da39fe
to
d9b1831
Compare
Signed-off-by: Boris Popovschi <zyqsempai@mail.ru>
AkihiroSuda
reviewed
Mar 4, 2020
libcontainer/rootfs_linux.go
Outdated
| @@ -867,7 +867,7 @@ func msMoveRoot(rootfs string) error { | |||
| } | |||
|
|
|||
| func chroot(rootfs string) error { | |||
| if err := unix.Chroot("."); err != nil { | |||
| if err := unix.Chroot(rootfs); err != nil { | |||
There was a problem hiding this comment.
should error out if rootfs != "." ?
There was a problem hiding this comment.
@AkihiroSuda Do you mean something like this?(check last commit)
There was a problem hiding this comment.
if filepath.Clean(rootfs) != os.Getwd(){ return errors.New(..) }? (Make sure to test it, ideally in CI)
There was a problem hiding this comment.
os.Getwd() returns absolute wd path, on other hand rootfs path here can be relative and we will get error even if they are point at same dir.
There was a problem hiding this comment.
if filepath.Abs(rootfs) != os.Getwd(){ return errors.New(..) }. The argument of Chroot() should remain ".".
Signed-off-by: Boris Popovschi <zyqsempai@mail.ru>
Signed-off-by: Boris Popovschi <zyqsempai@mail.ru>
AkihiroSuda
requested changes
Mar 22, 2020
|
so, should we close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2214
In order to avoid misunderstanding, it's better to use path parameter in chroot() func.
Signed-off-by: Boris Popovschi zyqsempai@mail.ru