Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add manpage cleanup #1232

Conversation

Mashimiao
Copy link

I think generated manpages should also need cleanup

Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com

I think generated manpages should also need cleanup

Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
@hqhq
Copy link
Contributor

hqhq commented Dec 19, 2016

LGTM

Approved with PullApprove

@cyphar
Copy link
Member

cyphar commented Dec 19, 2016

Eh, I think we should actually clean up how our man pages are generated overall (something like how I've done it in umoci or how ocid does it now). Specifically I don't really like the generation into ${MAN_DIR} -- it should be generated into the same directory and then use replacement macros to figure out the names and so on (which makes it more automated).

@crosbymichael
Copy link
Member

This change LGTM. We can revamp generation and cleanup together in a new PR.

@crosbymichael
Copy link
Member

crosbymichael commented Jan 9, 2017

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 5b8d1ec into opencontainers:master Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants