Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all the vendored libs to the latest versions #1334

Closed
wants to merge 3 commits into from
Closed

update all the vendored libs to the latest versions #1334

wants to merge 3 commits into from

Conversation

mcuadros
Copy link
Contributor

@mcuadros mcuadros commented Feb 20, 2017

The current build is broken if you try to use libcontainer as library in other project, since is using a old version of runtime-spce.

I tried to update the vendoring, but I found that its using a old version. I just updated the vendoring to the latest version for all the packages and to use the latest Godep version (was a very old version for 1.5.x)

Also I updated the CI, to run the tests properly with the changes introduced by Godep

One test is failing just tell me if the tests is wrong now and I should change it, or I should fix the behavior of the function:

time="2017-02-20T11:52:41Z" level=warning msg="os: process already finished" 
--- FAIL: TestExecInError (0.32s)
	execin_test.go:245: executable file not found error not delivered to stdio:

Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
@mcuadros mcuadros changed the title fix compiling errors with master runtime-spec update all the vendored libs to the latest versions Feb 20, 2017
@hqhq
Copy link
Contributor

hqhq commented Feb 21, 2017

@mcuadros Thanks for doing this, can you separate these changes to different PRs? Such like move Godep update into a PR and show how you did it, so we can make sure you're doing it right. Otherwise it's hard to review all these changes.

Thanks.

@cyphar
Copy link
Member

cyphar commented Feb 21, 2017

The current build is broken if you try to use libcontainer as library in other project, since is using a old version of runtime-spce.

If the issue is an old version of runtime-spec then please only update that vendor and not the entire vendor folder. The current state of this PR is effectively impossible for us to review.

Also, yeah we've been planning on fixing the issue that is us using godep for a while. Sorry that you had to use it to do this PR.

@cyphar
Copy link
Member

cyphar commented Feb 21, 2017

One test is failing just tell me if the tests is wrong now and I should change it, or I should fix the behavior of the function:

If that test is failing then this PR has broken something with regards to how console handling is done internally. I can't really help more than that unless you break up the PR a bit more -- it's a bit difficult to figure out which part of the 100kline diff broke it.

Do the integration tests pass for you (make integration)?

@mcuadros
Copy link
Contributor Author

Is true that is hard to review, I will do it tomorrow morning.

The main problem is that the old Godeps is complete obsolete, I cannot run any command on-top of it. I will try to do it by hand.

So I will make a PR updating the Godeps to the new version and after updating the libraries.

@mcuadros
Copy link
Contributor Author

I already split this is the first PR #1337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants