make the install steps more clear in README.md

[carmark]

No description provided.

[mrunalp]

$GOPATH/src to be compatible with go get.

[carmark]

I noticed that the Godeps directory is existed in the repository, and the go get is slow and unreliable, as it does not provide repeatable builds.

[mrunalp]

Yes, but other go get packages are generally under the src directory hence just to be consistent :)

[mrunalp]

LGTM

[stevvooe]

This doesn't work for all GOPATH setups. I'd recommend go get -d to do a download only fetch into the GOPATH.

[carmark]

@stevvooe

This doesn't work for all GOPATH setups.

Could you please specify why it will not work for all GOPATH setups?

I'd recommend go get -d to do a download only fetch into the GOPATH.

As I mentioned, I noticed that the Godeps directory is existed in the repository, and the go get is slow and unreliable, as it does not provide repeatable builds.

[wking]

On Tue, Jun 23, 2015 at 03:41:52PM -0700, Lei Xue wrote:

-git clone https://github.com/opencontainers/runc
+git clone https://github.com/opencontainers/runc $GOPATH/src/github.com/opencontainers/runc

@stevvooe

This doesn't work for all GOPATH setups.

Could you please specify why it will not work for all GOPATH
setups?

GOPATH is a delimited list of tree roots 1. So
/path/to/a:/path/to/b is a valid GOPATH, but ‘git clone’ isn't going
to like /path/to/a:/path/to/b/src/github.com/opencontainers/runc ;).

[pnasrat]

I guess it depends do we expect the audience of the README to potentially be new to go. Note http://golang.org/doc/code.html uses $GOPATH

Users who have setup a more complex GOPATH probably know what they are doing and can adjust the command. So I think it's fine to have the simple case in the README Alternately one could use

go get -d github.com/opencontainers/runc

[pnasrat]

Also as remove largest suffix prefix is POSIX defined http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_03_01 we can also use

${GOPATH%%:*}

[stevvooe]

@carmark go get -d github.com/opencontainers/runc and git clone https://github.com/opencontainers/runc $GOPATH/src/github.com/opencontainers/runc are roughly equivalent, except go get correctly handles GOPATH. We should avoid path munging in this build file.

Please carefully read Writing Go Code for more information on correctly setting up your development environment and managing GOPATH. Most build problems with Go stem from not following those concepts carefully.

[carmark]

Thank you to clarify this, please close this PR if it is unnecessary to keep it.

[stevvooe]

@carmark I think we can merge this if you make the suggested change to use go get -d.

[carmark]

@stevvooe
Thanks, I have updated it based on the suggested change, could you please review it and merge it?

[stevvooe]

LGTM

[duglin]

Won't this fail if GOPATH is a list?

[philips]

Yes, it will fail, this isn't the right thing to do!

[duglin]

In my PR ( #23) I just put:
#cd to runc dir
not ideal, but at least its accurate. Thoughts?