vendor: github.com/moby/sys/mountinfo v0.2.0 #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Sep 16, 2020
| @@ -22,5 +22,5 @@ require ( | |||
| // NOTE: urfave/cli must be <= v1.22.1 due to a regression: https://github.com/urfave/cli/issues/1092 | |||
| github.com/urfave/cli v1.22.1 | |||
| github.com/vishvananda/netlink v1.1.0 | |||
| golang.org/x/sys v0.0.0-20200728102440-3e129f6d46b1 | |||
| golang.org/x/sys v0.0.0-20200909081042-eff7692f9009 | |||
There was a problem hiding this comment.
note that the golang.org/x/sys updates are incompatible with the containerd/console package, and break compile on macOS. A fix is open for this in containerd/console#40
I don't think anything in runc is compiled on macOS currently, so probably not a blocker, but it may cause issues for projects that use runc as a go module, as it will force them to update to a newer golang.org/x/sys version
|
@kolyshkin @cyphar ptal |
AkihiroSuda
previously approved these changes
Sep 16, 2020
kolyshkin
reviewed
Sep 16, 2020
full diff: moby/sys@mountinfo/v0.1.3...mountinfo/v0.2.0 Bug fixes: - Fix path unescaping for paths with double quotes Improvements: - Mounted: speed up by adding fast paths using openat2 (Linux-only) and stat - Mounted: relax path requirements (allow relative, non-cleaned paths, symlinks) - Unescape fstype and source fields - Documentation improvements Testing/CI: - Unit tests: exclude darwin - CI: run tests under Fedora 32 to test openat2 - TestGetMounts: fix for Ubuntu build system - Makefile: fix ignoring test failures - CI: add cross build Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bump_mountinfo
branch
from
f5c35b4
to
71c10e3
Compare
|
@AkihiroSuda I pushed again, so looks like you need to re-approve 😅 |
AkihiroSuda
approved these changes
Sep 17, 2020
cyphar
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full diff: moby/sys@mountinfo/v0.1.3...mountinfo/v0.2.0
Bug fixes:
Improvements:
Testing/CI: