tests/integration: nits #2592
Merged
tests/integration: nits #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use update_config like in all the other places. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
tests-int-nits
branch
2 times, most recently
from
0c8b135
to
b068da0
Compare
|
Interesting... my changes resulting in spec generated by Indeed, runtime-spec says pids.limit is required: @AkihiroSuda mind to take a look? Or should we NOT run this for the rootless case? |
|
Shouldn't be required even for rootful, I guess |
|
OK this is caused by runc/tests/integration/helpers.bash Line 108 in d636ad6 which is indeed an invalid |
With some grep|awk help, found a few places where the containers supposed to be removed in teardown() weren't. To find container names: grep -E '^[[:space:]]*\<_*_*runc\>.*\<(create|run|restore)\>' Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Commit d78ae51 adds this line, but the file is never created. This is probably a leftover from copy-pasting update.bats code. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Fix - whitespace at EOL - empty lines at EOF Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
tests-int-nits
branch
from
929526a
to
7efdb52
Compare
The purpose of the spec validation test is to make sure that config.json generated by runc spec is valid. Therefore, it does not depend on ROOTLESS_FEATURES. Taking that into account, and given the fact that this test involves cloning repos and building some code, it makes sense to not run it 4 times for various rootless features. Time it takes to execute spec.bats in rootless mode has improved. Before: real 0m21.286s user 0m37.837s sys 0m5.745s After: real 0m13.162s user 0m30.814s sys 0m4.050s Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Most of whatever is happening in the test cases is already available in setup_hello and teardown_hello. Use these. Rewrite the validation test to be more compact and not dependent on `pwd` value. Also, pinning xeipuuv/gojsonschema to a particular version is no longer required. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
tests-int-nits
branch
from
7efdb52
to
30601ef
Compare
|
@mrunalp @AkihiroSuda PTAL |
AkihiroSuda
approved these changes
Sep 25, 2020
mrunalp
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notable one is spec.bats simplification and speedup.
The rest is nits and minor fixes. Please see individual commits for details.