Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcontainer: remove aliases for deprecated functions #2999

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jun 4, 2021

These were deprecated and moved; the stubs were included in (at least) the last two (rc94, rc95) releases, so external consumers would have the chance to update their code.

Removing this so that this doesn't get into v1.0.0 GA

Proposed changelog entry (by @kolyshkin)

(goes to "Breaking changes" section)

  • Removed libcontainer/configs.Device* identifiers (deprecated since rc94, use libcontainer/devices)
  • Removed libcontainer/system.RunningInUserNS function (deprecated since rc94, use libcontainer/userns)

These were deprecated and moved; the stubs were included in the
last two (rc94, rc95) releases, so external consumers would have
the chance to update their code.

Removing this so that this doesn't get into v1.0.0 GA

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These were deprecated and moved; the stubs were included in the
last two (rc94, rc95) releases, so external consumers would have
the chance to update their code.

Removing this so that this doesn't get into v1.0.0 GA

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@kolyshkin @AkihiroSuda ptal

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin added this to the 1.0.0 milestone Jun 4, 2021
@kolyshkin kolyshkin merged commit 123a34d into opencontainers:master Jun 4, 2021
@kolyshkin kolyshkin mentioned this pull request Jun 4, 2021
7 tasks
@thaJeztah thaJeztah deleted the remove_deprecated_stubs branch June 4, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants