libcontainer/SPEC.md: fix /dev/stdio symlinks #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alban Thanks for the PR! Could you sign your commit? |
The spec uses symlinks to "/proc/1/..." but the implementation uses "/proc/self/...": see setupDevSymlinks (libcontainer/rootfs_linux.go). The implementation is more correct, so I'm changing the spec to match the implementation. Signed-off-by: Alban Crequy <alban.crequy@coreos.com>
|
@mrunalp sorry for the delay! I updated the commit. |
|
LGTM |
1 similar comment
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Oct 23, 2015
libcontainer/SPEC.md: fix /dev/stdio symlinks
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
ReadMe: Update content to match print order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec uses symlinks to "/proc/1/..." but the implementation uses
"/proc/self/...": see setupDevSymlinks (libcontainer/rootfs_linux.go).
The implementation is more correct, so I'm changing the spec to match
the implementation.