Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syscall to start loong64 support #3765

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhaixiaojuan
Copy link

The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.
Documentations:
ISA:
https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html
ABI:
https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html
More docs can be found at:
https://loongson.github.io/LoongArch-Documentation/README-EN.html

// +build linux
// +build arm64 amd64 mips mipsle mips64 mips64le ppc ppc64 ppc64le riscv64 s390x
// +build arm64 amd64 loong64 mips mipsle mips64 mips64le ppc ppc64 ppc64le riscv64 s390x

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seccomp needs to be updated too

"SCMP_ARCH_RISCV64": "riscv64",

const uint32_t C_AUDIT_ARCH_RISCV64 = AUDIT_ARCH_RISCV64;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and libseccomp-golang needs to be updated as well (see seccomp/libseccomp-golang#106)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and libseccomp-golang needs to be updated as well (see seccomp/libseccomp-golang#106)

Sorry, I didn't know that you had submitted a PR before submitting the PR (seccomp/libseccomp-golang#107), but there are some differences in the submitted code, please review

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seccomp needs to be updated too

"SCMP_ARCH_RISCV64": "riscv64",

const uint32_t C_AUDIT_ARCH_RISCV64 = AUDIT_ARCH_RISCV64;

I have updated it, please check

@kolyshkin kolyshkin marked this pull request as draft March 10, 2023 22:12
@kolyshkin
Copy link
Contributor

Let's wait until runc dependencies have loong64 supported. That includes:

  • golang (I think it is supported already)
  • x/sys/unix
  • libseccomp (not in a released version)
  • libseccomp-golang
  • what else?

Once all that is ready and released, we can add the support. Doing it earlier doesn't make much practical sense.

@zhaixiaojuan
Copy link
Author

@kolyshkin
Hi kolyshkin, Could you consider merging this PR(seccomp/libseccomp-golang#106) ?

algitbot pushed a commit to alpinelinux/aports that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants