Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] libct/cg: add misc controller to v1 drivers #3823

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Apr 10, 2023

This is just so that

  • the container can join the misc controller;
  • the `Destroy() can actually remove the cgroup.

This should fix the issue reported in kubernetes/kubernetes#112124 (comment)

(cherry picked from commit 611bbac / PR #3815.

Proposed changelog entry:

- Bare minimal support for cgroup v1 misc controller. (#3823)

This is just so that the container can join the misc controller.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit 611bbac)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin added this to the 1.1.6 milestone Apr 10, 2023
@kolyshkin kolyshkin mentioned this pull request Apr 10, 2023
@kolyshkin
Copy link
Contributor Author

This fixes the issue with Kubernetes and recent kernel adding misc controller.. I'm not exactly sure how misc controller is being created, but it's not being joined to or removed since runc knows nothing about it.

@cyphar
Copy link
Member

cyphar commented Apr 11, 2023

We probably want to make a proper MiscCgroup controller at some point since it's a real controller (I'm still not sure why it wasn't added to /sys/fs/resctl since that was created the last time a CPU-specific feature cgroup controller was proposed). But yeah, this is fine as a minimal implementation.

Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants