Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1] Add go 1.21 to CI #3976

Merged
merged 11 commits into from
Aug 10, 2023
Merged

[1.1] Add go 1.21 to CI #3976

merged 11 commits into from
Aug 10, 2023

Commits on Aug 9, 2023

  1. [1.1] ci/cirrus: use Go 1.20 

    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    bb2401e View commit details
    Browse the repository at this point in the history

  2. [1.1] ci/cirrus: use Go 1.19.x not 1.19 

    [XXX 1.1 note: the above subject and the rest of the commit message
is the original description from the cherry-picked commit which talks
about 1.19 -- while in fact it is now 1.20.]

This variable is used in curl to download a go release, so we are using
the initial Go 1.19 release in Cirrus CI, not the latest Go 1.19.x
release.

From the CI perspective, it makes more sense to use the latest release.

Add some jq magic to extract the latest minor release information
from the download page, and use it.

This brings Cirrus CI jobs logic in line with all the others (GHA,
Dockerfile), where by 1.20 we actually mean "latest 1.20.x".

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit 873d7bb)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    ecccc43 View commit details
    Browse the repository at this point in the history

  3. ci/cirrus: improve host_info 

    1. Do not use echo, as this results in lines like this:

	...
	echo "-----"
	-----
	...

2. Move "cat /proc/cpuinfo" to be the last one, as the output is usually
   very long.

3. Add "go version" to CentOS jobs.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit fd1a79f)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    ac31091 View commit details
    Browse the repository at this point in the history

  4. [1.1] ci/gha: rm unsup Go 1.19.x, add 1.21.x 

    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    1c52424 View commit details
    Browse the repository at this point in the history

  5. Fix running tests under Docker/Podman and cgroup v2 

    For "make integration", the tests are run inside a Docker/Podman
container. Problem is, if cgroup v2 is used, the in-container
/sys/fs/cgroup/cgroup.subtree_control is empty.

The added script, used as Docker entrypoint, moves the current process
into a sub-cgroup, and then adds all controllers in top-level
cgroup.subtree_control.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit cfc801b)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    37405ca View commit details
    Browse the repository at this point in the history

  6. ci: fix TestNilResources when systemd not available 

    Split the test into two -- for fs and systemd cgroup managers, and only
run the second one if systemd is available.

Prevents the following failure during `make unittest`:

> === RUN   TestNilResources
>     manager_test.go:27: systemd not running on this host, cannot use systemd cgroups manager
> --- FAIL: TestNilResources (0.22s)

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit 962019d)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    cff41a8 View commit details
    Browse the repository at this point in the history

  7. ci: fix TestOpenat2 when no systemd is used 

    A few cases relied on the fact that systemd is used, and thus
/sys/fs/cgroup/user.slice is available.

Guess what, in case of "make unittest" it might not be.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit 5c6b334)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    44a53f0 View commit details
    Browse the repository at this point in the history

  8. build(deps): bump actions/setup-go from 3 to 4 

    Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit e3cf217)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @dependabot @kolyshkin
    dependabot[bot] authored and kolyshkin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    a47c15b View commit details
    Browse the repository at this point in the history

  9. ci/gha: rm actions/cache from validate/deps job 

    Since commit e3cf217 actions/setup-go@v4 uses caching
implicitly, so it is no longer required.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit 083e978)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    5888c55 View commit details
    Browse the repository at this point in the history

  10. gha: disable setup-go cache for golangci job 

    Since commit e3cf217 actions/setup-go@v4 uses caching
implicitly, and olangci/golangci-lint-action also uses caching.

These two caches clash, resulting in multiple warnings in CI logs.

The official golangci-lint-action solution is to disable caching
for setup-go job (see [1]). Do the same.

[1] golangci/golangci-lint-action#704

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit 62cc13e)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    d398ad2 View commit details
    Browse the repository at this point in the history

  11. ci: bump golangci-lint, remove fixed exception 

    The exception was fixed by polyfloyd/go-errorlint#12
which eventually made its way into golangci-lint.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit 98317c1)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    bdbfe04 View commit details
    Browse the repository at this point in the history