Commits on Sep 24, 2023

1. sync: rename procResume -> procHooksDone …

   The old name was quite confusing, and with the addition of the
   procMountPlease sync message there are now multiple sync messages that
   are related to "resuming" runc-init.
   
   Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>

   

   cyphar authored and lifubang committed Sep 24, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for ccc7671
   • Browse repository at this point

   Copy the full SHA

   ccc7671 View commit details

   Browse the repository at this point in the history

2. sync: split init config (stream) and synchronisation (seqpacket) pipes …

   We have different requirements for the initial configuration and
   initWaiter pipe (just send netlink and JSON blobs with no complicated
   handling needed for message coalescing) and the packet-based
   synchronisation pipe.
   
   Tests with switching everything to SOCK_SEQPACKET lead to endless issues
   with runc hanging on start-up because random things would try to do
   short reads (which SOCK_SEQPACKET will not allow and the Go stdlib
   explicitly treats as a streaming source), so splitting it was the only
   reasonable solution. Even doing somewhat dodgy tricks such as adding a
   Read() wrapper which actually calls ReadPacket() and makes it seem like
   a stream source doesn't work -- and is a bit too magical.
   
   One upside is that doing it this way makes the difference between the
   modes clearer -- INITPIPE is still used for initWaiter syncrhonisation
   but aside from that all other synchronisation is done by SYNCPIPE.
   
   Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>

   

   cyphar authored and lifubang committed Sep 24, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 8da42aa
   • Browse repository at this point

   Copy the full SHA

   8da42aa View commit details

   Browse the repository at this point in the history