Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/gha: fix downloading Release.key #4079

Merged
merged 1 commit into from
Oct 20, 2023
Merged

ci/gha: fix downloading Release.key #4079

merged 1 commit into from
Oct 20, 2023

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Oct 20, 2023 •
edited

For some reason, since today

curl -fSsl https://download.opensuse.org/repositories/devel:/tools:/criu/xUbuntu_20.04/Release.key

does not produce any error, but there's no output either.

Switch to wget. Add -L to follow 3xx redirects.

While at it, ditch apt-key as it's not supposed to be used that way.

Fixes: #4078

@kolyshkin kolyshkin mentioned this pull request Oct 20, 2023
Merged
@kolyshkin kolyshkin marked this pull request as ready for review October 20, 2023 00:32
@kolyshkin kolyshkin added this to the 1.2.0 milestone Oct 20, 2023
@kolyshkin kolyshkin added the backport/1.1-pr A backport to 1.1.x release. label Oct 20, 2023
@kolyshkin
Copy link
Contributor Author

Looks like it fixes the issue (I'm not sure what's wrong with curl or download.opensuse.org but apparently switching to wget works.

@lifubang
Copy link
Member

I'm not sure what's wrong with curl or download.opensuse.org

using -v to look what's happened:
< HTTP/2 302
< cache-control: public, max-age=144
< content-length: 0
< date: Fri, 20 Oct 2023 00:44:31 GMT
< location: https://downloadcontentcdn.opensuse.org/repositories/devel:/tools:/criu/xUbuntu_20.04/Release.key
< server: Apache
<

So, add -L to follow 302 redirection maybe fix it too.

@lifubang
Copy link
Member

I'm surprising that, in the past there was no cdn for download site in opensuse.org?

@kolyshkin
ci/gha: fix downloading Release.key
f944d7b 
Since today, the URL from download.opensuse.org started returning a
HTTP 302 redirect, so -L option for curl is needed to follow it.

While at it, remove apt-key as per its man page recommendation:

> Note: Instead of using this command a keyring should be placed
> directly in the /etc/apt/trusted.gpg.d/ directory with a descriptive
> name and either "gpg" or "asc" as file extension.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Contributor Author

So, add -L to follow 302 redirection maybe fix it too.

Thanks, updated to use curl -fSsLl.

This was referenced Oct 20, 2023
Merged
Merged
Closed
cyphar
cyphar approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyphar cyphar merged commit 27eb67a into opencontainers:main Oct 20, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifubang lifubang lifubang approved these changes

@cyphar cyphar cyphar approved these changes

Assignees
No one assigned
Labels
area/ci backport/1.1-pr A backport to 1.1.x release.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

GHA CI broken
3 participants
@kolyshkin @lifubang @cyphar