Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] Fix set nofile rlimit error #4277

Merged

Commits on May 16, 2024

  1. deprecate libct.system.Execv

    This is not used since commit dac4171.
    It will be removed in v1.2.0
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    (cherry picked from commit dbd0c33)
    Signed-off-by: lifubang <lifubang@acmcoder.com>
    kolyshkin authored and lifubang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    debf52a View commit details
    Browse the repository at this point in the history
  2. libct: fix a comment

    Do not refer to the function which was removed.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    (cherry picked from commit bac5064)
    Signed-off-by: lifubang <lifubang@acmcoder.com>
    kolyshkin authored and lifubang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    fbddb71 View commit details
    Browse the repository at this point in the history
  3. runc exec: setupRlimits after syscall.rlimit.init() completed

    Issue: opencontainers#4195
    Since https://go-review.googlesource.com/c/go/+/476097, there is
    a get/set race between runc exec and syscall.rlimit.init, so we
    need to call setupRlimits after syscall.rlimit.init() completed.
    
    Signed-off-by: lifubang <lifubang@acmcoder.com>
    (cherry picked from commit a853a82)
    Signed-off-by: lifubang <lifubang@acmcoder.com>
    lifubang committed May 16, 2024
    Configuration menu
    Copy the full SHA
    83ecd11 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. use go 1.18 in go.mod

    The complete generic features are supported since go 1.18
    
    Signed-off-by: lfbzhm <lifubang@acmcoder.com>
    lifubang committed May 17, 2024
    Configuration menu
    Copy the full SHA
    42c2ab2 View commit details
    Browse the repository at this point in the history
  2. libct: clean cached rlimit nofile in go runtime

    As reported in issue opencontainers#4195, the new version(since 1.19) of go runtime
    will cache rlimit-nofile. Before executing execve, the rlimit-nofile
    of the process will be restored with the cache. In runc, this will
    cause the rlimit-nofile set by the parent process for the container
    to become invalid. It can be solved by clearing the cache.
    
    Signed-off-by: ls-ggg <335814617@qq.com>
    (cherry picked from commit f9f8abf)
    Signed-off-by: lifubang <lifubang@acmcoder.com>
    (cherry picked from commit da68c8e)
    Signed-off-by: lifubang <lifubang@acmcoder.com>
    ls-ggg authored and lifubang committed May 17, 2024
    Configuration menu
    Copy the full SHA
    d7a29a3 View commit details
    Browse the repository at this point in the history
  3. update/add some tests for rlimit

    issues:
    opencontainers#4195
    opencontainers#4265 (comment)
    
    Signed-off-by: lifubang <lifubang@acmcoder.com>
    (cherry picked from commit 4ea0bf8)
    Signed-off-by: lfbzhm <lifubang@acmcoder.com>
    lifubang committed May 17, 2024
    Configuration menu
    Copy the full SHA
    2992049 View commit details
    Browse the repository at this point in the history
  4. fix comments for ClearRlimitNofileCache

    Signed-off-by: lifubang <lifubang@acmcoder.com>
    (cherry picked from commit a35f7d8)
    Signed-off-by: lifubang <lifubang@acmcoder.com>
    lifubang committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c918058 View commit details
    Browse the repository at this point in the history