Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.13 #4318

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

lifubang
Copy link
Member

@lifubang lifubang commented Jun 10, 2024

[1.1.13] - 2024-06-13

There is no certainty in the world. This is the only certainty I have.

Important Notes

Fixed

Changed

@lifubang lifubang force-pushed the release-1.1.13 branch 2 times, most recently from 4c6703a to 52c7556 Compare June 10, 2024 01:17
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but other reviewers pelase note that there are two PRs referenced not yet merged. We need to merge those first

@kolyshkin kolyshkin added this to the 1.1.13 milestone Jun 11, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@kolyshkin
Copy link
Contributor

kolyshkin commented Jun 11, 2024

This LGTM, but other reviewers pelase note that there are two PRs referenced not yet merged. We need to merge those first

Basically we're looking into the relevant milestone (1.1.13 in this case) as well as PRs with backport/todo/1.1 label (including the closed/merged ones!)

@kolyshkin
Copy link
Contributor

@lifubang can you rebase this? Has to be done from the command line because we want these commits to be signed.

@kolyshkin
Copy link
Contributor

@cyphar PTAL

CHANGELOG.md Outdated Show resolved Hide resolved
@cyphar
Copy link
Member

cyphar commented Jun 13, 2024

@lifubang Can you please PGP-sign these commits?

Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit.

CHANGELOG.md Outdated Show resolved Hide resolved
@lifubang lifubang force-pushed the release-1.1.13 branch 2 times, most recently from 46d1e1a to 3fad6d3 Compare June 13, 2024 08:47
@lifubang
Copy link
Member Author

Can you please PGP-sign these commits?

Resigned with gpg.

Signed-off-by: lifubang <lifubang@acmcoder.com>
Signed-off-by: lifubang <lifubang@acmcoder.com>
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @kolyshkin said he wanted to do the release this time, so he can merge it and all that jazz. Thanks!

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kolyshkin kolyshkin merged commit ed40695 into opencontainers:release-1.1 Jun 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants