Put the changelog of v1.1.13 after v1.2.0-rc.1 #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lfbzhm <lifubang@acmcoder.com>
It's better to say something like "Changelog: sort entries by version" |
Merged
cyphar
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
LGTM, though the commit message @kolyshkin suggested would be nicer.
|
@kolyshkin You didn't approve the PR 😉 |
AkihiroSuda
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #4321 (comment)
I think most of us think that the timeline order and the version order in
CHANGELOG.mdare ok, but if we are more like the version order, I can change it.We should change it before we do the release
v1.2.0-rc.2.