Add white list for bind mount check #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -299,6 +299,22 @@ func checkMountDestination(rootfs, dest string) error { | |||
| invalidDestinations := []string{ | |||
| "/proc", | |||
| } | |||
| // White list, it should be sub directories of invalid destionations | |||
hqhq
force-pushed
the
hq_bindmount_whitelist
branch
from
6f3fadb
to
566abcc
Compare
| @@ -299,6 +299,22 @@ func checkMountDestination(rootfs, dest string) error { | |||
| invalidDestinations := []string{ | |||
| "/proc", | |||
| } | |||
| // White list, it should be sub directories of invalid destinations | |||
| validDestinations := []string{ | |||
There was a problem hiding this comment.
Can you add why these files were chosen and use cases?
Fixes: opencontainers#400 It would be useful to use fuse to isolate proc info. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
hqhq
force-pushed
the
hq_bindmount_whitelist
branch
from
566abcc
to
9c1242e
Compare
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Jan 6, 2016
Add white list for bind mount check
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
…stem-owners config-linux: Make “don't modify filesystem permissions” generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #400
It would be useful to use fuse to isolate proc info.
Signed-off-by: Qiang Huang h.huangqiang@huawei.com