address issue #797 by adding additional documentation #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
|
Minor note: the PR also changes the usage from I changed the arguments to be empty because there are no arguments to runc only options. |
|
LGTM |
1 similar comment
|
LGTM |
hqhq
added a commit
to hqhq/runc
that referenced
this pull request
Jul 19, 2016
Follow up opencontainers#939 Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
hqhq
added a commit
to hqhq/runc
that referenced
this pull request
Jul 19, 2016
Follow up opencontainers#939 Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove confusion over the wording of the list api.. This PR documents use of the global
--root valueoption for specifying "the given root" where stats are stored and from which containers are listed via therunc listcommand.Signed-off-by: Mike Brown brownwm@us.ibm.com