spec: add scheduler entity #1188

giuseppe · 2023-03-16T14:45:41Z

extend the process struct to represent scheduling attributes for a process based on the sched_setattr(2) syscall.

I've been playing with crun and it is currently implemented as an annotation:

but I think this makes sense as part of the runtime-specs without the custom hack.

config.md

specs-go/config.go

config.md

specs-go/config.go

rhatdan · 2023-03-18T12:28:12Z

LGTM
@kolyshkin @mrunalp PTAL

mrunalp

LGTM

utam0k · 2023-03-21T04:37:19Z

Thanks, @giuseppe

utam0k · 2023-03-21T04:44:37Z

specs-go/config.go

+	Policy LinuxSchedulerPolicy `json:"policy"`
+
+	// Nice is the nice value for the process, which affects its priority.
+	Nice int32 `json:"nice"`


If you know, please let me know, does this apply to process groups?:pray: Or only one process?
I tried reading the man page but it just wasn't clear to me.
https://man7.org/linux/man-pages/man2/sched_setattr.2.html

from my understanding that is only for one process or thread:

The sched_setattr() system call sets the scheduling policy and associated attributes for the thread whose ID is specified in pid. If pid equals zero, the scheduling policy and attributes of the calling thread will be set

do you see a different behavior?

I agree with you. I thought the user would expect the nice value to be applied to all processes in the container? What do you think?

How about specifying whether it applies to the container init process alone or to all processes in the container?

utam0k · 2023-03-21T04:54:53Z

config.md

+        * `SCHED_BATCH`
+        * `SCHED_ISO`
+        * `SCHED_IDLE`
+        * `SCHED_DEADLINE`


SCHED_DEADLINE seems to sometimes return an EBUSY error. Do you want the error numbers to follow these when the set fails?
https://man7.org/linux/man-pages/man2/sched_setattr.2.html

There seems to be some difficulty in using SCHED_DEADLINE with cpuset. can we consider removing SCHED_DEADLINE from support?
https://www.kernel.org/doc/Documentation/scheduler/sched-deadline.txt

I don't think it is required to support it, I am just listing the possible values for now (e.g. SCHED_ISO is not even implemented yet)

I will leave it up to you to specify about it in the oci-spec, but there are some things that probably cannot be handled. I thought users might expect to be able to use them.

utam0k

@giuseppe
Sorry if I am causing trouble by leaving comments from the outside. If it doesn't seem necessary and the maintainer is satisfied, please ignore it and merge.

specs-go/config.go

extend the process struct to represent scheduling attributes for a process based on the sched_setattr(2) syscall. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

giuseppe · 2023-05-11T08:50:17Z

@thaJeztah could you PTAL?

thaJeztah

LGTM (thanks for the ping; sorry, thought I already did 🙈 ❤️)

thaJeztah · 2023-05-11T08:58:52Z

Any more reviewers needed, or are we good to go? (forgot how many we want for such changes in this repository 🙈)

thaJeztah · 2023-05-11T08:59:07Z

Ah! Thanks @AkihiroSuda 😂

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <k0ma@utam0k.jp>

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Co-authored-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Co-authored-by: utam0k <k0ma@utam0k.jp> Signed-off-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Co-authored-by: lifubang <lifubang@acmcoder.com> Signed-off-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

giuseppe requested review from AkihiroSuda, crosbymichael, cyphar, dqminh, hqhq, kolyshkin, mrunalp, thaJeztah, tianon and vbatts as code owners March 16, 2023 14:45

giuseppe mentioned this pull request Mar 16, 2023

scheduler: use sched_setattr containers/crun#1166

Merged

AkihiroSuda reviewed Mar 16, 2023

View reviewed changes

config.md Outdated Show resolved Hide resolved

AkihiroSuda reviewed Mar 16, 2023

View reviewed changes

config.md Outdated Show resolved Hide resolved

AkihiroSuda reviewed Mar 16, 2023

View reviewed changes

config.md Outdated Show resolved Hide resolved

AkihiroSuda reviewed Mar 16, 2023

View reviewed changes

specs-go/config.go Outdated Show resolved Hide resolved

giuseppe force-pushed the add-scheduler branch from 80ef061 to cc22c94 Compare March 16, 2023 20:11

AkihiroSuda reviewed Mar 17, 2023

View reviewed changes

config.md Show resolved Hide resolved

giuseppe force-pushed the add-scheduler branch from cc22c94 to 5a350bc Compare March 17, 2023 09:20

AkihiroSuda reviewed Mar 17, 2023

View reviewed changes

specs-go/config.go Outdated Show resolved Hide resolved

giuseppe force-pushed the add-scheduler branch from 5a350bc to 61bb8e5 Compare March 17, 2023 10:59

AkihiroSuda approved these changes Mar 17, 2023

View reviewed changes

mrunalp approved these changes Mar 20, 2023

View reviewed changes

utam0k mentioned this pull request Mar 21, 2023

Add scheduler entity containers/youki#1706

Open

utam0k reviewed Mar 21, 2023

View reviewed changes

AkihiroSuda added this to the v1.1.0 milestone Mar 28, 2023

AkihiroSuda mentioned this pull request Mar 28, 2023

Release v1.1.0-rc.2 #1192

Merged

thaJeztah reviewed Apr 17, 2023

View reviewed changes

specs-go/config.go Outdated Show resolved Hide resolved

spec: add scheduler entity

8947849

extend the process struct to represent scheduling attributes for a process based on the sched_setattr(2) syscall. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

giuseppe force-pushed the add-scheduler branch from ea29fd9 to 8947849 Compare April 18, 2023 10:24

AkihiroSuda requested a review from thaJeztah April 25, 2023 11:45

thaJeztah approved these changes May 11, 2023

View reviewed changes

AkihiroSuda merged commit 0983f1d into opencontainers:main May 11, 2023
3 checks passed

AkihiroSuda mentioned this pull request May 22, 2023

Release v1.1.0-rc.3 #1208

Merged

12 tasks

AkihiroSuda mentioned this pull request Jun 10, 2023

Support process.scheduler opencontainers/runc#3895

Closed

AkihiroSuda mentioned this pull request Jun 26, 2023

Release v1.1.0 #1213

Merged

12 tasks

utam0k added a commit to utam0k/runc that referenced this pull request Aug 4, 2023

Support process.scheduler

0f88b67

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <k0ma@utam0k.jp>

utam0k mentioned this pull request Aug 4, 2023

Support process.scheduler opencontainers/runc#3962

Closed

utam0k added a commit to utam0k/runc that referenced this pull request Aug 4, 2023

Support process.scheduler

8eba1cc

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <k0ma@utam0k.jp>

utam0k added a commit to utam0k/runc that referenced this pull request Aug 4, 2023

Support process.scheduler

83c45c6

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <k0ma@utam0k.jp>

lifubang pushed a commit to lifubang/runc that referenced this pull request Sep 25, 2023

Support process.scheduler

109dce2

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

lifubang pushed a commit to lifubang/runc that referenced this pull request Sep 25, 2023

Support process.scheduler

c58e2fa

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

lifubang mentioned this pull request Sep 25, 2023

[Carry 3962] Support process.scheduler opencontainers/runc#4025

Merged

lifubang pushed a commit to lifubang/runc that referenced this pull request Sep 25, 2023

Support process.scheduler

ecd3e1a

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

lifubang pushed a commit to lifubang/runc that referenced this pull request Sep 25, 2023

Support process.scheduler

8d1145b

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

lifubang pushed a commit to lifubang/runc that referenced this pull request Sep 28, 2023

Support process.scheduler

89f7db7

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

lifubang pushed a commit to lifubang/runc that referenced this pull request Sep 28, 2023

Support process.scheduler

3087839

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

lifubang pushed a commit to lifubang/runc that referenced this pull request Sep 28, 2023

Support process.scheduler

dc3aa07

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Signed-off-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

lifubang pushed a commit to lifubang/runc that referenced this pull request Oct 3, 2023

Support process.scheduler

99335a8

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Co-authored-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

lifubang pushed a commit to lifubang/runc that referenced this pull request Oct 3, 2023

Support process.scheduler

eded31e

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Co-authored-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

lifubang pushed a commit to lifubang/runc that referenced this pull request Oct 3, 2023

Support process.scheduler

25b3d41

Spec: opencontainers/runtime-spec#1188 Fix: opencontainers#3895 Co-authored-by: utam0k <k0ma@utam0k.jp> Signed-off-by: lifubang <lifubang@acmcoder.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

spec: add scheduler entity #1188

spec: add scheduler entity #1188

giuseppe commented Mar 16, 2023

rhatdan commented Mar 18, 2023

mrunalp left a comment

utam0k commented Mar 21, 2023

utam0k Mar 21, 2023 •

edited

giuseppe Mar 21, 2023 •

edited

utam0k Mar 21, 2023

utam0k Mar 21, 2023

utam0k Mar 21, 2023

giuseppe Mar 21, 2023

utam0k Mar 21, 2023

utam0k left a comment •

edited

giuseppe commented May 11, 2023

thaJeztah left a comment

thaJeztah commented May 11, 2023

thaJeztah commented May 11, 2023

spec: add scheduler entity #1188

spec: add scheduler entity #1188

Conversation

giuseppe commented Mar 16, 2023

rhatdan commented Mar 18, 2023

mrunalp left a comment

Choose a reason for hiding this comment

utam0k commented Mar 21, 2023

utam0k Mar 21, 2023 • edited

Choose a reason for hiding this comment

giuseppe Mar 21, 2023 • edited

Choose a reason for hiding this comment

utam0k Mar 21, 2023

Choose a reason for hiding this comment

utam0k Mar 21, 2023

Choose a reason for hiding this comment

utam0k Mar 21, 2023

Choose a reason for hiding this comment

giuseppe Mar 21, 2023

Choose a reason for hiding this comment

utam0k Mar 21, 2023

Choose a reason for hiding this comment

utam0k left a comment • edited

Choose a reason for hiding this comment

giuseppe commented May 11, 2023

thaJeztah left a comment

Choose a reason for hiding this comment

thaJeztah commented May 11, 2023

thaJeztah commented May 11, 2023

utam0k Mar 21, 2023 •

edited

giuseppe Mar 21, 2023 •

edited

utam0k left a comment •

edited