Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.1.0 #1213

Merged
merged 4 commits into from Jul 22, 2023
Merged

Release v1.1.0 #1213

merged 4 commits into from Jul 22, 2023
+44 −55

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Jun 26, 2023 •
edited

Changes (v1.1.0-rc.3 → v1.1.0)

Minor fixes and documentation:

Changes (v1.1.0-rc.2 → v1.1.0-rc.3)

Additions:

Minor fixes and documentation:

Changes (v1.1.0-rc.1 → v1.1.0-rc.2)

Additions

Minor fixes and documentation

Changes (v1.0.2 → v1.1.0-rc.1)

Breaking changes (but rather conforms to the existing runc implementation)

Deprecations

Additions

Minor fixes and documentation

[runtime-spec VOTE] tag ac7bb22 as v1.1.0 (closes Mon Jul 3 06:02:25 AM UTC 2023) (at least 8 of 12 maintainers needed for this resolution to pass):

Closes #1052

@AkihiroSuda
ChangeLog: Document changes since v1.1.0-rc.3
5430e36 
Through 07dd1f4 (2023-06-23)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Jun 26, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 26, 2023
Closed
@h-vetinari
Copy link
Contributor

Very happy to see this! :)

I propose to merge the release notes between the different rc's, and split off even-more-minor-than-minor changes into "Documentation, CI & Governance", see below the fold

Merged release notes

Breaking changes (but rather conforms to the existing runc implementation)

Deprecations

Additions

Minor fixes

Documentation, CI & Governance

giuseppe
giuseppe approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

utam0k
utam0k approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

Thanks, @AkihiroSuda, for your coordination in releasing v1.1.0

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jun 26, 2023 •
edited

I propose to merge the release notes between the different rc's

I'm not sure about this.
We didn't do this for v1.0.0.

vbatts
vbatts approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧁

@h-vetinari
Copy link
Contributor

h-vetinari commented Jun 26, 2023 •
edited

I'm not sure about this.
We didn't do this for v1.0.0.

1.0.0 was a long time ago... I realize it's easier to just reflect what happened per rc, but now a reader needs to scroll over 30-40 almost irrelevant lines to get to the key content of the new version. Note that in a similar discussion for runc, Aleksa brought up https://keepachangelog.com as a reference, which says:

Guiding Principles

  • Changelogs are for humans, not machines
  • The same types of changes should be grouped.
  • [...]

The proposed changelog is not human-friendly.

hqhq
hqhq approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@hqhq hqhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tianon
tianon approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (https://github.com/opencontainers/runtime-spec/compare/v1.0.2..ac7bb22)

I agree that a more human-friendly changelog would be nice, and if someone wanted to do the work to create one, we should probably integrate/use it, but the actual spec bits of the above comparison are relatively approachable (honestly, probably more approachable for implementers than the changelog/release notes would be anyhow).

@h-vetinari
Copy link
Contributor

I agree that a more human-friendly changelog would be nice, and if someone wanted to do the work to create one, we should probably integrate/use it

I've made a proposal in the comment above, here again in plain-text for easy of use. It's based on appending the various iterations to rc1 (per section), and then splitting off "Documentation, CI & Governance" (because "Minor fixes" ended up being a giant heap, many of which weren't spec-relevant; obviously there are other subjective choices that could be made in grouping/ordering/etc.)


### Breaking changes (but rather conforms to the existing runc implementation)
  * config: change prestart hook spec to match reality (#1169)

### Deprecations
  * config-linux: mark memory.kernel[TCP] as NOT RECOMMENDED (#1093)

### Additions
  * cgroup: add cgroup v2 support (#1040)
  * seccomp: allow to override errno return code (#1041)
  * seccomp: Add support for SCMP_ACT_KILL_PROCESS (#1044)
  * Update seccomp architectures to support RISCV64 (#1059)
  * Add support for SCMP_ACT_KILL_THREAD (#1064)
  * Add Seccomp Notify support using UNIX sockets and container metadata (#1074)
  * config-linux: Add Intel RDT CMT and MBM Linux support (#1076)
  * seccomp: allow to override default errno return code (#1087)
  * Introduce zos as platform (#1095)
  * config-linux: add idle option for container cgroup (#1136)
  * config-linux: add CFS bandwidth burst (#1120)
  * IDMapping field for mount point (#1143)
  * schema: add cpu idle (#1145)
  * add domainname spec entity (#1156)
  * config-linux: add memory.checkBeforeUpdate (#1158)
  * seccomp: Add flag SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV (#1161)
  * config-linux: add support for rsvd hugetlb cgroup (#1116)
  * features: add `features.md` to formalize the `runc features` JSON (#1130)
  * config-linux: add support for time namespace (#1151)
  * config: add scheduler entity (#1188)
  * config: Add I/O Priority Configuration for process group in Linux Containers (#1191)

### Minor fixes
  * seccomp: fix go-specs for errnoRet (#1042)
  * Define State for container and runtime namespace (#1045)
  * Add State status constants to spec-go (#1046)
  * config.go: make umask a pointer (#1058)
  * Update State structure to use the new ContainerState type (#1056)
  * Fix int64 and uint64 type value ranges (#1060)
  * Fix seccomp notify inconsistencies (#1096)
  * runtime should WARN / ignore capabilities that cannot be granted (#1094)
  * config-linux: clarify the handling of ClosID RDT parameter (#1104)
  * defs-zos: [Fix] prevent schema parsers from hitting recursion-loop while resolving types. (#1117)
  * fix the lifecycle reference in the states listing (#1118)
  * specify cgroup ownership semantics (#1123)
  * config-linux: MAY reject an unfit cgroup (#1125)
  * cgroup ownership: clarify that some files may not exist (#1137)
  * schema: update README.md (#1083)
  * schema: make with golang 1.16 (#1084)
  * Update Windows CPU comments (#1144)
  * specs-go: export LinuxBlockIODevice (#1103)
  * config-linux: update type of LinuxCPU.Idle to *int64 (#1146)
  * Add available LinuxSeccompFlags (#1138)
  * config-linux: clarify where device nodes can be created (#1148)
  * runtime: remove `When serialized in JSON, the format MUST adhere to the following pattern` (#1178)
  * config: clarify Linux mount options (#1181)
  * schema: fix schema for timeOffsets (#1193)
  * schema: remove duplicate keys (#1195)
  * config-linux: clarify I/O throttling differences between cgroup v1 and v2 (#1194)
  * releases: use +dev as in-development suffix (#1198)
  * features: update Example (#1204)
  * schema: fix definition for ioPriority (#1206)
  * features: add a note to avoid confusion about annotations (#1212)

### Documentation, CI & Governance
  * MAINTAINERS: Add @cyphar as maintainer (#1043)
  * Add Giuseppe Scrivano as a runtime spec maintainer (#1048)
  * Remove superfluous 'an' (#1049)
  * docs: Added enclave OCI runtime rune to implementations (#1055)
  * Change all references from whitelist to allowlist (#1054)
  * MAINTAINERS: update vbatts email (#1065)
  * travis: fix go_import_path (#1072)
  * Makefile: Fix golint URL used in go get (#1075)
  * config-linux: fix personality link (#1086)
  * README: Fix broken link for charter (#1091)
  * add youki to implementations.md (#1126)
  * Switch to GitHub Actions, CODEOWNERS, etc. (#1128)
  * typo: seccompFD -> seccompFd (#1133)
  * fix RFC link (#1153)
  * maintainer updates as per #1101 (#1150)
  * GOVERNANCE: correct the Charter URL (#1157)
  * CODEOWNERS: sync with MAINTAINERS (#1160)
  * Update CI to Go 1.20 (#1179)
  * config-linux: fix url error (#1184)
  * config-linux: chore: Update `ociVersion` in example (#1199)
  * MAINTAINERS: add Toru Komatsu (utam0k) (#1201)
  * glossary: `s/features document/Features structure/g` (#1203)
  * CODEOWNER: Add Toru Komatsu(@utam0k) to sync with MAINTAINERS (#1207)
  * README.md: update chat information (#1210)
  * Remove outdated meeting.ics (#1211)

AkihiroSuda and others added 3 commits June 28, 2023 22:32
@AkihiroSuda @h-vetinari
ChangeLog: squash v1.1.0-rc.1...v1.1.0
d56ba70 
Co-Authored-By: H. Vetinari <h.vetinari@gmx.com>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
version: release v1.1.0
0625254 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
version: release v1.1.0+dev
3f552ce 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Member Author

Squashed the ChangeLog (Thanks to @h-vetinari)

@AkihiroSuda
Copy link
Member Author

ping @opencontainers/runtime-spec-maintainers
Please vote (or explicitly abstain)

@utam0k
Copy link
Member

utam0k commented Jul 10, 2023

👋 Hi, @crosbymichael @dqminh @kolyshkin @mrunalp @thaJeztah
You have the last right to vote to release the new version v1.1.0 of the OCI Runtime Spec. Please vote for it.

thaJeztah
thaJeztah approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-vetinari
Copy link
Contributor

Sounds like quorum has been reached. :)

@h-vetinari h-vetinari mentioned this pull request Jul 11, 2023
Merged
@AkihiroSuda AkihiroSuda mentioned this pull request Jul 18, 2023
Merged
@AkihiroSuda
Copy link
Member Author

Let me merge the spec v1.1 PR and this blog PR simultaneously:

@AkihiroSuda AkihiroSuda merged commit e8c4134 into opencontainers:main Jul 22, 2023
3 checks passed
@AkihiroSuda
Copy link
Member Author

https://github.com/opencontainers/runtime-spec/releases/tag/v1.1.0

@utam0k utam0k mentioned this pull request Jan 5, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbatts vbatts vbatts approved these changes

@giuseppe giuseppe giuseppe approved these changes

@tianon tianon tianon approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@cyphar cyphar cyphar approved these changes

@hqhq hqhq hqhq approved these changes

@utam0k utam0k utam0k approved these changes

@crosbymichael crosbymichael Awaiting requested review from crosbymichael crosbymichael is a code owner

@dqminh dqminh Awaiting requested review from dqminh dqminh is a code owner

@kolyshkin kolyshkin Awaiting requested review from kolyshkin kolyshkin is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Prepare / Tag v1.1.0 release
9 participants
@AkihiroSuda @h-vetinari @utam0k @vbatts @giuseppe @tianon @thaJeztah @cyphar @hqhq