Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINTAINERS: add Toru Komatsu (utam0k) #1201

Merged
merged 1 commit into from May 19, 2023
Merged

MAINTAINERS: add Toru Komatsu (utam0k) #1201

merged 1 commit into from May 19, 2023

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented May 1, 2023 •
edited

@utam0k is a maintainer of youki and has been actively contributing to the spec:
https://github.com/search?q=repo%3Aopencontainers%2Fruntime-spec+type%3Aissue+involves%3Autam0k&type=pullrequests

Maintainer votes (at least 8 of 11 maintainers needed for this resolution to pass):

@AkihiroSuda
MAINTAINERS: add Toru Komatsu (utam0k)
39bd2ef 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda mentioned this pull request May 1, 2023
Open
@utam0k
Copy link
Member

utam0k commented May 1, 2023

Thanks a lot 🙏

@AkihiroSuda
Copy link
Member Author

ping @opencontainers/runtime-spec-maintainers

@caniszczyk
Copy link
Contributor

@AkihiroSuda you can always send a reminder to the dev@oci mailing list too

@estesp
Copy link
Contributor

estesp commented May 9, 2023

Not a maintainer, but definitely in favor!

cyphar
cyphar approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! He'd be an amazing addition as a maintainer to our project.

thaJeztah
thaJeztah approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

giuseppe
giuseppe approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbatts
vbatts approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😺

@utam0k
Copy link
Member

utam0k commented May 16, 2023

👋Hi @crosbymichael @mrunalp @dqminh @tianon @hqhq@kolyshkin, This PR still needs three more approvals. There are several regular PRs already out there that I'd like to review. Currently, I'm unable to do so. Would you be able to help with the review? 🙏

@hqhq
Copy link
Contributor

hqhq commented May 16, 2023

LGTM

kolyshkin
kolyshkin approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utam0k
Copy link
Member

utam0k commented May 17, 2023

Hello @crosbymichael @mrunalp @dqminh @tianon
This humble PR is sitting at 7/8 approvals. It's just one review away from reaching it is being merged. It feels like waiting for the last piece of pizza to be delivered 🍕 Can someone help deliver this 'slice' of approval? 😄🙏

fuweid
fuweid reviewed May 18, 2023
View reviewed changes
Copy link

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mrunalp
Copy link
Contributor

mrunalp commented May 18, 2023

LGTM

1 similar comment
@dqminh
Copy link
Contributor

dqminh commented May 18, 2023

LGTM

@utam0k
Copy link
Member

utam0k commented May 18, 2023

@fuweid @mrunalp @dqminh
Thanks for your reaction 🙏

@AkihiroSuda
Copy link
Member Author

9 approvers (including myself), so I'm merging this.
Welcome @utam0k

@AkihiroSuda AkihiroSuda merged commit 7529d10 into opencontainers:main May 19, 2023
3 checks passed
@AkihiroSuda
Copy link
Member Author

@caniszczyk Could you invite @utam0k ?

@caniszczyk
Copy link
Contributor

done welcome!

@AkihiroSuda
Copy link
Member Author

Thank you!

@utam0k
Copy link
Member

utam0k commented May 19, 2023

I am happy to participate! Thanks.

@AkihiroSuda AkihiroSuda mentioned this pull request May 22, 2023
Merged
12 tasks
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 26, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid left review comments

@vbatts vbatts vbatts approved these changes

@giuseppe giuseppe giuseppe approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@cyphar cyphar cyphar approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

@crosbymichael crosbymichael Awaiting requested review from crosbymichael crosbymichael is a code owner

@dqminh dqminh Awaiting requested review from dqminh dqminh is a code owner

@hqhq hqhq Awaiting requested review from hqhq hqhq is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@tianon tianon Awaiting requested review from tianon tianon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet