Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtimetest: fix error return #505

Merged
merged 1 commit into from
Nov 3, 2017
Merged

runtimetest: fix error return #505

merged 1 commit into from
Nov 3, 2017

Conversation

zhouhao3
Copy link

@zhouhao3 zhouhao3 commented Nov 3, 2017

Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com

runtimetest: fix error return
3c9cdc5 
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
wking
wking approved these changes Nov 3, 2017
View reviewed changes
Copy link
Contributor

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

And I'd rather see the earlier IsNotExist block dropped too (why create our own string for that case?), but that could happen infollow-up work.

@liangchenye
Copy link
Member

liangchenye commented Nov 3, 2017 •
edited by caniszczyk

LGTM

Approved with PullApprove

1 similar comment
@Mashimiao
Copy link

Mashimiao commented Nov 3, 2017 •
edited by caniszczyk

LGTM

Approved with PullApprove

@Mashimiao Mashimiao merged commit dea65b0 into opencontainers:master Nov 3, 2017
@zhouhao3 zhouhao3 deleted the err-fix-runtimetest branch November 3, 2017 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhouhao3 @liangchenye @Mashimiao @wking