Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check RootOnWindowsRequired #584

Merged
merged 1 commit into from
Feb 28, 2018
Merged

Conversation

liangchenye
Copy link
Member

Signed-off-by: Liang Chenye liangchenye@huawei.com

Signed-off-by: Liang Chenye <liangchenye@huawei.com>
@liangchenye liangchenye mentioned this pull request Feb 28, 2018
44 tasks
@liangchenye
Copy link
Member Author

  • rename 'RootOnNonHyperVRequired' to 'RootOnNonWindowsRequired'
  • check RootOnWindowsRequired
  • add unit test about RootOnWindowsRequired

PTAL @q384566678

@zhouhao3
Copy link

zhouhao3 commented Feb 28, 2018

LGTM

Approved with PullApprove

@zhouhao3 zhouhao3 merged commit d2b5e63 into opencontainers:master Feb 28, 2018
@liangchenye liangchenye deleted the windows branch February 28, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants