validation: add more test cases for private & slave propagations #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouhao3
reviewed
Jun 7, 2018
| "github.com/opencontainers/runtime-tools/validation/util" | ||
| ) | ||
|
|
||
| func testLinuxRootPropagation(t *tap.T, propMode string) error { |
There was a problem hiding this comment.
@q384566678 Removed t. Thanks!
dongsupark
force-pushed
the
dongsu/test-rootfs-prop
branch
from
1e72c1b
to
e2d34c1
Compare
added 2 commits
June 8, 2018 08:59
To make the test code simpler, squash tests that are relevant to rootfs propagation into a single file, linux_rootfs_propagation.go. Also print TAP output for rootfs_propagation tests. Signed-off-by: Dongsu Park <dongsu@kinvolk.io>
We should test rootfs propagation modes, not only shared and unbindable, but also slave and private. Signed-off-by: Dongsu Park <dongsu@kinvolk.io>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should test rootfs propagation modes, not only shared and unbindable, but also slave and private.
Also squash tests that are relevant to rootfs propagation into a single file,
linux_rootfs_propagation.go.Also print TAP output for rootfs_propagation tests.