Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file names and permissions #323

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

redhatrises
Copy link
Collaborator

  • Add file permissions constants
  • Files shouldn't be executable
  • Files shouldn't use spaces in file names for multi-OS support

@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #323 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   79.09%   79.06%   -0.03%     
==========================================
  Files          38       38              
  Lines        1430     1428       -2     
==========================================
- Hits         1131     1129       -2     
  Misses        246      246              
  Partials       53       53
Impacted Files Coverage Δ
pkg/cli/docs/gitbook/gitbook.go 80% <ø> (-1.82%) ⬇️
pkg/cli/docs/gitbook/gitbookSummaries.go 90.47% <100%> (ø) ⬆️
pkg/cli/docs/gitbook/gitbookComponents.go 100% <100%> (ø) ⬆️
pkg/cli/docs/gitbook/gitbookCertification.go 95.18% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60895be...5aa7472. Read the comment docs.

- Add file permissions constants
- Add function to handle filenames
- Add function to handle writing files
- Files shouldn't be executable
- Files shouldn't use spaces in file names for multi-OS support
@shawndwells
Copy link
Member

Quick skim: function names need consistent capitalization. replaceParentheses vs FileNameHandler

@redhatrises
Copy link
Collaborator Author

@shawndwells exported function names are capitalized e.g. FileNameHandler. Non-exported function names are not capitalized e.g. replaceParentheses. The function names are using correct Golang syntax. See https://stackoverflow.com/questions/38616687/which-way-to-name-a-function-in-go-camelcase-or-semi-camelcase

@shawndwells shawndwells merged commit c5b89cc into opencontrol:master Jul 31, 2018
@shawndwells
Copy link
Member

thanks @redhatrises

@redhatrises redhatrises deleted the fix_file_perms_name branch July 31, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants