Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation Experiment view: make it possible to customise a graph panel and have it serialised to / retrieved from a SED-ML file #1426

Closed
59 tasks done
agarny opened this issue Sep 26, 2017 · 0 comments
Closed
59 tasks done

Simulation Experiment view: make it possible to customise a graph panel and have it serialised to / retrieved from a SED-ML file #1426

agarny opened this issue Sep 26, 2017 · 0 comments
Assignees
@agarny
Labels
Feature
Milestone
0.6

Comments

@agarny
Copy link
Contributor

agarny commented Sep 26, 2017 •
edited

We can now change the colour (and other things) of a graph (see issue #591). So, it would be nice to be able to change the background colour of a graph panel, as well as of its grid lines.

Things to do:

  • Have our current "Graphs" panel to rename automatically to "Graph Panel" or "Graphs", depending on which one is active.
  • Have a way to toggle between graph panel specific settings and graphs specific settings.
  • Have some context menu items for “Graph Panel Settings” and “Graphs Settings" to open our new “Graph Panel” panel and select the graph panel settings or graphs settings, respectively.
  • Remove the "Logarithmic X Axis" and "Logarithmic Y Axis" menu items from a graph panel's context menu.
  • In the graph panel side, allow the customisation of the:
    • Background colour.
    • Font size.
    • Foreground colour.
    • Grid lines:
      • Style.
      • Width.
      • Colour.
    • Point coordinates:
      • Style.
      • Width.
      • Colour.
      • Font colour.
    • Title.
    • X axis:
      • Logarithmic scale.
      • Title.
    • Y axis:
      • Logarithmic scale.
      • Title.
    • Zoom region:
      • Style.
      • Width.
      • Colour.
      • Font colour.
      • Filled.
      • Fill colour.
  • Make sure that the expanded/collapsed state of all graph panel editor's sections remains the same when switching to another graph panel or file.
  • Add SED-ML support for the new settings:
    • Background colour.
    • Font size.
    • Foreground colour.
    • Grid lines:
      • Style.
      • Width.
      • Colour.
    • Point coordinates:
      • Style.
      • Width.
      • Colour.
      • Font colour.
    • Title.
    • X axis:
      • Logarithmic scale.
      • Title.
    • Y axis:
      • Logarithmic scale.
      • Title.
    • Zoom region:
      • Style.
      • Width.
      • Colour.
      • Font colour.
      • Filled.
      • Fill colour.
@agarny agarny added the Feature label Sep 26, 2017
@agarny agarny added this to the 0.6 milestone Sep 26, 2017
@agarny agarny self-assigned this Sep 26, 2017
@agarny agarny mentioned this issue Sep 27, 2017
Closed
agarny added a commit to agarny/opencor that referenced this issue Oct 6, 2017
@agarny
SimulationExperiment view: renamed our "Graphs" panel to "Graph Panel" (
c8efb87 
opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 25, 2017
@agarny
Added a menu icon (opencor#1426).
bfff6da
agarny added a commit to agarny/opencor that referenced this issue Oct 25, 2017
@agarny
Collapsible widget: added a menu icon to the right (opencor#1426).
eddb371
agarny added a commit to agarny/opencor that referenced this issue Oct 25, 2017
@agarny
Collapsible widget: added support for a menu to the right (opencor#1426…
ea96359 
…).
agarny added a commit to agarny/opencor that referenced this issue Oct 25, 2017
@agarny
SimulationExperiment view: our "Graph Panel" panel now has a menu to …
8f69b8f 
…switch between graphs and graph panel settings (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 25, 2017
@agarny
SimulationExperiment view: our "Graph Panel" panel now has a menu to …
ca567a1 
…switch between graphs and graph panel settings (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 25, 2017
@agarny
SimulationExperiment view: our "Graph Panel" panel now has a menu to …
c5a8662 
…switch between graphs and graph panel settings (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 25, 2017
@agarny
SimulationExperiment view: our "Graph Panel" panel now has a menu to …
d228225 
…switch between graphs and graph panel settings (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 26, 2017
@agarny
Renamed src/simulationexperimentviewinformationgraphpanelwidget.* to …
2a597c6 
…src/simulationexperimentviewinformationgraphpanelandgraphswidget.* (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 26, 2017
@agarny
Renamed src/simulationexperimentviewinformationgraphpanelwidget.* to …
49a73cc 
…src/simulationexperimentviewinformationgraphpanelandgraphswidget.* (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 27, 2017
@agarny
SimulationExperiment view: added the shell of a graph panel and graph…
e083d8a 
…s specific property editor (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 27, 2017
@agarny
SimulationExperiment view: added the shell of a graph panel and graph…
baf2672 
…s specific property editor (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 28, 2017
@agarny
SimulationExperiment view: removed the shell of a graph panel and gra…
e010025 
…phs specific property editor (opencor#1426).

Indeed, refactoring the Graphs property editor was proving to be too
tedious, not to mention that this meant several instances of our
context menu, etc. one for each graph panel. So, not optimal at all.
agarny added a commit to agarny/opencor that referenced this issue Oct 28, 2017
@agarny
SimulationExperiment view: some work on distinguishing our (future) g…
c84b08c 
…raph panel property editor from our (existing) graphs property editor (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 28, 2017
@agarny
SimulationExperiment view: some work on distinguishing our graph pane…
34ce446 
…l property editor from our graphs property editor (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 29, 2017
@agarny
SimulationExperiment view: some work on distinguishing our graph pane…
c6b8efc 
…l property editor from our graphs property editor (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 29, 2017
@agarny
SimulationExperiment view: some work on distinguishing our graph pane…
d283369 
…l property editor from our graphs property editor (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 29, 2017
@agarny
SimulationExperiment view: some work on distinguishing our graph pane…
2f5cc31 
…l property editor from our graphs property editor (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 29, 2017
@agarny
SimulationExperiment view: added some menu items to get access to our…
0fe40ba 
… Graph Panel and Graphs settings (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 29, 2017
@agarny
SimulationExperiment view: added some menu items to get access to our…
df9da73 
… Graph Panel and Graphs settings (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 29, 2017
@agarny
SimulationExperiment view: can now select and show our graph panel or…
ad2825c 
… graphs settings from a graph panel’s context menu (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 29, 2017
@agarny
SimulationExperiment view: removed the "Logarithmic X Axis" and "Loga…
10ba9b3 
…rithmic Y Axis" menu items from a graph panel's context menu (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 30, 2017
@agarny
SimulationExperiment view: some work on populating our graph panel pr…
7832e0d 
…operty editor (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 30, 2017
@agarny
SimulationExperiment view: some work on populating our graph panel pr…
1e068d4 
…operty editor (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 30, 2017
@agarny
SimulationExperiment view: can now modify the colour, font size and a…
2eefc31 
…xes’ scale of a graph panel (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Oct 31, 2017
@agarny
SimulationExperiment view: some minor refactoring (opencor#1426).
3281c6c
agarny added a commit to agarny/opencor that referenced this issue Nov 10, 2017
@agarny
SimulationExperiment view: make sure that the expanded/collapsed stat…
713983a 
…e of all graph panel editor's sections remains the same when switching to another graph panel or file (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 10, 2017
@agarny
SimulationExperiment view: export all graph panels, even if they don'…
b7e12d3 
…t contain graphs (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 10, 2017
@agarny
SimulationExperiment view: export all graph panels, even if they don'…
65002f0 
…t contain graphs (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 10, 2017
@agarny
SimulationExperiment view: put back a graph panel's log scale informa…
b166b8a 
…tion (opencor#1426).

I thought I could get away with putting that information as annotation,
but SED-ML explicitly requires it to be at the curve level…
agarny added a commit to agarny/opencor that referenced this issue Nov 10, 2017
@agarny
SimulationExperiment view: now have SED-ML support for the background…
07f8e0f 
… colour (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 10, 2017
@agarny
SimulationExperiment view: now have SED-ML support for the foreground…
f1f8462 
… colour (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 10, 2017
@agarny
SimulationExperiment view: better handle the further initialisation o…
5877d1f 
…f our view due to a SED-ML file (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 10, 2017
@agarny
SimulationExperiment view: make sure that all our graph panels get pr…
fa0b5ae 
…operly initialised when opening a SED-ML file / COMBINE archive (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 12, 2017
@agarny
SimulationExperiment view: make sure that all our graph panels get th…
442ffbe 
…e correct height when adding a graph panel or opening a SED-ML file with several graph panels (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 12, 2017
@agarny
Slight update to our what is new page (opencor#1426).
2168d82
@agarny agarny changed the title Simulation Experiment view: make it possible to change the background colour of a graph panel Simulation Experiment view: make it possible to customise a graph panel Nov 12, 2017
agarny added a commit to agarny/opencor that referenced this issue Nov 13, 2017
@agarny
GraphPanel widget: make sure that we are properly aligned when adding…
9c3eec2 
… a graph panel when another has a Y title (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 13, 2017
@agarny
GraphPanel widget: make sure that our graph panels are properly align…
efce428 
…ed (opencor#1426).

Indeed, if we had one graph panel, added a title to its Y axis, added
another graph panel and also wanted to add a title to its Y axis, then
only the Y axis title of the first graph panel would be visible. That
is, until we would, say, pan the second graph panel.

This was because the QwtScaleWidget for the Y axis of the second graph
panel didn’t have its internals updated. To ‘fix’ this, we have to
subclass QwtScaleWidget, so that we could call its layoutScale() method…
agarny added a commit to agarny/opencor that referenced this issue Nov 14, 2017
@agarny
GraphPanel widget: improved our addition/removal of graph panels (ope…
2a4567d 
…ncor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 14, 2017
@agarny
SimulationExperiment view: now have SED-ML support for the font size (o…
8c4a484 
…pencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 14, 2017
@agarny
SimulationExperiment view: now have SED-ML support for the title (ope…
62c9007 
…ncor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 14, 2017
@agarny
GraphPanel widget: improved our removeAllGraphPanels() method (openco…
8082eff 
…r#1426).

Indeed, until now, we were removing all the graph panels, but the first
one. This was not only arbitrary, but if the graph panel had been
customised (e.g., a title had been set), then it means that it would
still be there. So, now, we add a graph panel (since we need at least
one graph panel) and then really remove all the other graph panels.
agarny added a commit to agarny/opencor that referenced this issue Nov 14, 2017
@agarny
SimulationExperiment view: make sure that our graph panels are proper…
d788feb 
…ly reinitialised when reloading a SED-ML file (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 14, 2017
@agarny
SED-ML support: some minor refactoring and make sure that a line widt…
8321aae 
…h is an integer (and not a double) greater than zero (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 14, 2017
@agarny
SimulationExperiment view: now have SED-ML support for the grid lines…
b11756c 
… settings (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 14, 2017
@agarny
SimulationExperiment view: now have SED-ML support for the grid lines…
55f6cc3 
… settings (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 15, 2017
@agarny
SimulationExperiment view: now have SED-ML support for the point coor…
52a1a2c 
…dinates settings (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 15, 2017
@agarny
SimulationExperiment view: now have SED-ML support for the X axis and…
e2f48c4 
… Y axis settings (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 15, 2017
@agarny
SimulationExperiment view: now have SED-ML support for the zoom regio…
99b9d0b 
…n settings (opencor#1426).
agarny added a commit to agarny/opencor that referenced this issue Nov 15, 2017
@agarny
Slight update to our downloads and what is new pages (opencor#1426).
21ca3b3
@agarny agarny closed this as completed in 2020fe0 Nov 15, 2017
@agarny agarny changed the title Simulation Experiment view: make it possible to customise a graph panel Simulation Experiment view: make it possible to customise a graph panel and have it serialised to / retrieved from a SED-ML file Nov 15, 2017
agarny added a commit to agarny/opencor that referenced this issue Nov 27, 2017
@agarny
GraphPanel widget: don’t force the alignment when not necessary (open…
b452fac 
…cor#1426).

This had been modified in commit
9c3eec2 to ensure proper alignment
when adding a graph panel when another had a Y title. However, this was
unnecessarily realigning things and therefore slowing things down (a
lot). So, back to what we originally had. As for adding a graph panel
when another has a Y title, it looks like our various changes (as part
of issues opencor#1426 and opencor#1171) indirectly addresses it since everything is
still fine.
@agarny agarny mentioned this issue Nov 29, 2017
Closed
@agarny agarny mentioned this issue Mar 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agarny agarny

Labels
Feature
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
1 participant
@agarny