Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation Experiment view: some results may not be plotted at all #1613

Closed
agarny opened this issue Apr 11, 2018 · 1 comment
Closed

Simulation Experiment view: some results may not be plotted at all #1613

agarny opened this issue Apr 11, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@agarny
Copy link
Contributor

agarny commented Apr 11, 2018

Some time ago, Qt added a new signal/slot mechanism, which also applies to single shots. Thus, to check for the availability of simulation results, we used to have:

QTimer::singleShot(0, this, SLOT(callCheckSimulationResults()));

which we then replaced with:

QTimer::singleShot(0, this, &SimulationExperimentViewWidget::callCheckSimulationResults);

However, to have the "new" syntax results in only the beginning of some traces to be rendered (using our noble_1962_local.sedml and by pressing down the F9 key):

screen shot 2018-04-11 at 7 29 32 pm

while everything works as expected using the "old" syntax (!!):

screen shot 2018-04-11 at 7 29 48 pm

Not sure what the cause is (@dbrnz, any ideas?). I tried to create a small test case (so I could report the issue to the Qt guys, but to no avail). It's true that our use of QTimer::singleShot() here is somewhat special since it is effectively a loop that stops when there are no more simulation results or when the simulation is stopped by the user. So, although it ought to work no matter which syntax we use, we should clearly revert this particular instance of QTimer::singleShot(). (I checked the other instances of QTimer::singleShot() and they should be fine since they are not loops.)

@agarny agarny added the Task label Apr 11, 2018
@agarny agarny added this to the 0.6 milestone Apr 11, 2018
@agarny agarny self-assigned this Apr 11, 2018
agarny added a commit to agarny/opencor that referenced this issue Apr 11, 2018
agarny added a commit to agarny/opencor that referenced this issue Apr 11, 2018
@agarny agarny changed the title Simulation Experiment view: some results may be not be plotted at all Simulation Experiment view: some results may not be plotted at all Apr 11, 2018
@agarny agarny closed this as completed in fa6d385 Apr 11, 2018
@agarny
Copy link
Contributor Author

agarny commented Apr 13, 2018

Reopening since the problem was definitely not with the syntax used for Qt::singleShot(), but with the fact that we were not properly handling the addition of a new run.

@agarny agarny reopened this Apr 13, 2018
agarny added a commit to agarny/opencor that referenced this issue Apr 13, 2018
@agarny agarny closed this as completed in ba30578 Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant