Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: time series data request exceeding limit #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lim-yoona
Copy link

Description

I implemented the logic of multiple requests in the QueryRangeMetric function of internal/metrics/common/common.go. I think it is more complicated to get the time information from the name parameter, so I need to pass in three parameters: start, end and interval. This results in many calls to this function needing to be modified, so there are more changes.

If it feels inappropriate, I will modify the code again.

Related issue

#3

@lim-yoona
Copy link
Author

lim-yoona commented Oct 10, 2023

Add incoming parameters:

func QueryRangeMetric(name string, start, end, interval uint64, results *chan MetricResult) {}

or getting the time information from the name parameter:

nameSlice := strings.Split(name,"&")
str := nameSlice[0]
start := nameSlice[1][6:]
end := nameSlice[2][4:]
interval := nameSlice[3][5:]

Then use strconv to convert the string to uint64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant