[feat]: curvefs: merge two rpc into one rpc when makenode #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
201341
force-pushed
the
swj/opt-makenode
branch
5 times, most recently
from
6018699
to
106a550
Compare
2 tasks
201341
force-pushed
the
swj/opt-makenode
branch
from
106a550
to
2ca6b85
Compare
|
cicheck |
|
@SeanHai PTAL |
SeanHai
reviewed
Aug 25, 2023
curvefs/proto/metaserver.proto
Outdated
| @@ -114,6 +114,10 @@ message CreateDentryRequest { | |||
| required uint32 copysetId = 2; | |||
| required uint32 partitionId = 3; | |||
| required Dentry dentry = 4; | |||
| required bool enableSumInDir = 5; | |||
There was a problem hiding this comment.
- required need change to optional for compatible upgrade.
- enableSumInDir is not needed and update to parent inode directly, the function enablesumInDir will be discarded.
- new file length is 0 and length here is not needed
There was a problem hiding this comment.
For FuseOpLink And FuseOpSymLink, length is not zero, So length is needed?
201341
force-pushed
the
swj/opt-makenode
branch
6 times, most recently
from
80f2d22
to
c95616d
Compare
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
SeanHai
reviewed
Sep 5, 2023
| std::string key = GetDentryCacheKey(dentry.parentinodeid(), dentry.name()); | ||
| NameLockGuard lock(nameLock_, key); | ||
| MetaStatusCode ret = metaClient_->CreateDentry(dentry); | ||
| MetaStatusCode ret = metaClient_->CreateDentry(dentry, |
There was a problem hiding this comment.
You can get time here and no need to pass it from above.
| @@ -274,6 +274,8 @@ FSStatusCode MetaserverClient::CreateDentry( | |||
| d->set_txid(0); | |||
| d->set_type(FsFileType::TYPE_DIRECTORY); | |||
| request.set_allocated_dentry(d); | |||
| request.set_time(0); | |||
There was a problem hiding this comment.
It may be more appropriate to use real time
| << ", type: " << type | ||
| << ", isCreate: " << isCreate; | ||
| // already be deleted | ||
| return MetaStatusCode::OK; | ||
| } | ||
|
|
||
| NameLockGuard lg(inodeLock_, GetInodeLockName(fsId, parentInodeId)); |
There was a problem hiding this comment.
The namelock should get before inodeStorage_->Get
201341
force-pushed
the
swj/opt-makenode
branch
from
c95616d
to
e421f66
Compare
|
cicheck |
|
LGTM! |
SeanHai
approved these changes
Sep 5, 2023
wu-hanqing
reviewed
Sep 6, 2023
curvefs/proto/metaserver.proto
Outdated
Comment on lines
117
to
118
| optional uint64 time = 5; | ||
| optional uint32 time_ns = 6; |
There was a problem hiding this comment.
you can use Time in L290
| MetaStatusCode UpdateInodeWhenCreateOrRemoveSubNode(uint32_t fsId, | ||
| uint64_t inodeId, FsFileType type, bool isCreate); | ||
| MetaStatusCode UpdateInodeWhenCreateOrRemoveSubNode( | ||
| Dentry dentry, |
There was a problem hiding this comment.
Suggested change
| Dentry dentry, | |
| const Dentry& dentry, |
curvefs/src/metaserver/partition.h
Outdated
Comment on lines
60
to
61
| uint64_t now, | ||
| uint32_t now_ns); |
There was a problem hiding this comment.
ditto, use Time in proto
Signed-off-by: swj <1186093704@qq.com>
201341
force-pushed
the
swj/opt-makenode
branch
from
e421f66
to
4cce35b
Compare
|
cicheck |
wu-hanqing
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2548
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List