translate Chinese annotations to English annotations #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
|
good job, I'll review it, but it's too many files changed, so may be a long time will be needed. |
aspirer
approved these changes
Sep 20, 2023
src/chunkserver/op_request.h
Outdated
| * op data: refers to the data serialized by the request through protobuf | ||
| * @param request: Chunk Request | ||
| * @param data: The data content contained in the request | ||
| * @param log: Provide parameters, store serialized data, and ensure the data by the user= Nullptr |
There was a problem hiding this comment.
ensure the data!=Nullptr by the user
|
My review content:
TODO for Contributor @koko2pp ：
Thank you very much for your contribution. Great work~ |
|
Tips: |
Cyber-SiKu
approved these changes
Sep 21, 2023
|
cicheck |
1 similar comment
|
cicheck |
|
cicheck |
1 similar comment
|
cicheck |
… and rebase all conficts.
koko2pp
force-pushed
the
translateToEn
branch
from
078cc1b
to
12fbff3
Compare
|
cicheck |
1 similar comment
|
cicheck |
|
Maybe you can retry ci after rebase. |
… and rebase all conficts.
… and rebase all conficts.
Signed-off-by: koko2pp <spfrom1999@163.com>
change docs website Signed-off-by: Wangpan <aspirer2004@gmail.com> chore: prepare for rebase style: Apply Clang format to modified files ,and restore patch files, and rebase all conficts. style: Apply Clang format to modified files ,and restore patch files, and rebase all conficts. style: Apply Clang format to modified files and restore patch files. style: Apply Clang format to modified files ,and restore patch files, and rebase all conficts. doc: add changelog for v2.7. Signed-off-by: Wine93 <wine93.info@gmail.com> Update CHANGELOG-2.7.md Signed-off-by: Wangpan <aspirer2004@gmail.com> update curve-arch.png Signed-off-by: Wangpan <aspirer2004@gmail.com> Code formatting changes Signed-off-by: koko2pp <spfrom1999@163.com>
|
cicheck |
|
cicheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2576
Problem Summary: translate Chinese annotations to English annotations
What is changed and how it works?
What's Changed: The Chinese comments in the code files have been converted into English comments.
How it Works: Write a GO script. For various programming languages, extract all comments from code files using different regular expressions, then determine whether the comments contain Chinese characters. If there are Chinese characters, use the Baidu Translate API to translate the Chinese comments into English comments, and then write them back to the file.
Side effects(Breaking backward compatibility? Performance regression?): None
Check List