chunkserver: fix bug about trash bytes metric #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
recheck |
5 similar comments
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
wu-hanqing
reviewed
Mar 23, 2021
| @@ -164,6 +166,8 @@ class Trash { | |||
| // 回收站中chunk的个数 | |||
| Atomic<uint32_t> chunkNum_; | |||
There was a problem hiding this comment.
Does chunkNum_ is the number of chunk file and snapshot file ?
When chunkFilePool_ and walPool_ refer to the same pool, should chunkNum_ also include wal chunk file ?
There was a problem hiding this comment.
This issue is left to fix by future PR
ilixiaocui
reviewed
Mar 23, 2021
| LOG(ERROR) << "rename " << dirPath << " to " << dst << " error"; | ||
| return -1; | ||
| } | ||
| uint32_t chunkNum = CountChunkNumInCopyset(dst); |
There was a problem hiding this comment.
CountChunkNumInCopyset does not contain wal file?
There was a problem hiding this comment.
This issue is left to fix by future PR
There was a problem hiding this comment.
There is expiredAfterSec_ seconds interval between RecycleCopySet() and RecycleChunksAndWALInDir() for the same copyset directory，so how it causes concurrency issues? See NeedDelete
ilixiaocui
approved these changes
Mar 23, 2021
ilixiaocui
pushed a commit
to ilixiaocui/curve
that referenced
this pull request
Feb 6, 2023
update Keptn mentees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List