chunkserver: fix crc issues #405
Conversation
|
recheck |
| @@ -307,6 +318,10 @@ class CSChunkFile { | |||
| return lfs_->Read(fd_, buf, offset + pageSize_, length); | |||
| } | |||
|
|
|||
| inline int readMetaData(char* buf, off_t offset, size_t length) { | |||
There was a problem hiding this comment.
why not use the existing function?
?There was a problem hiding this comment.
why not use the existing function?
?
done
src/chunkserver/scan_manager.cpp
Outdated
| job->taskLock.WRLock(); | ||
| job->task.localMap.Clear(); | ||
| job->task.followerMap.clear(); | ||
| job->task.waitingNum = 3; |
There was a problem hiding this comment.
it's better to use
curve/src/chunkserver/copyset_node.h
Line 284 in c3418be
There was a problem hiding this comment.
it's better to use
curve/src/chunkserver/copyset_node.h
Line 284 in c3418be
to get the number of replica rather than hard code 3.
done
| request->set_sendscanmaptimeoutms(timeoutMs_); | ||
| request->set_sendscanmapretrytimes(retry_); | ||
| request->set_sendscanmapretryintervalus(retryIntervalUs_); | ||
| if (scanChunkMetaPage) { |
There was a problem hiding this comment.
for scan meta page, you can just set request->set_readmetapage(true), ellipsis set_offset/set_size and member variable chunkMetaPageSize_
There was a problem hiding this comment.
for scan meta page, you can just set
request->set_readmetapage(true), ellipsisset_offset/set_sizeand member variablechunkMetaPageSize_
Although offset and length is not needed in datastore and chunkfile, LOG and build scanmap is need. Otherwise more judgment is needed.
|
recheck |
SeanHai
force-pushed
the
curve_discard_flatten
branch
3 times, most recently
from
9be32d7
to
bfb7ec5
Compare
SeanHai
force-pushed
the
curve_discard_flatten
branch
from
bfb7ec5
to
e743b93
Compare
* Update README.md
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List