change client log level #94
Conversation
wu-hanqing
force-pushed
the
change-log-level
branch
3 times, most recently
from
2dd2436
to
44f6f62
Compare
| @@ -309,7 +309,7 @@ void ClientClosure::OnRpcFailed() { | |||
| MetricHelper::IncremTimeOutRPCCount(fileMetric_, reqCtx_->optype_); | |||
| } | |||
|
|
|||
| LOG_EVERY_N(ERROR, 10) << OpTypeToString(reqCtx_->optype_) | |||
| LOG_EVERY_SECOND(WARNING) << OpTypeToString(reqCtx_->optype_) | |||
There was a problem hiding this comment.
这里改成warning是为啥?是否client出现超时也不报警了？ 还有如果是超时以外的错误是否需要ERROR报警？
There was a problem hiding this comment.
这里只是一个rpc异常，比如超时，socket断开。但是后续会对请求进行重试，所以没必要ERROR
| @@ -392,6 +404,8 @@ int FileClient::StatFile(const std::string& filename, | |||
| int ret; | |||
| if (mdsClient_ != nullptr) { | |||
| ret = mdsClient_->GetFileInfo(filename, userinfo, &fi); | |||
| LOG_IF(ERROR, ret != LIBCURVE_ERROR::OK) | |||
There was a problem hiding this comment.
GetFileInfo 失败这种情况是否包含 文件不存在的情况， 如果文件不存在那么不需要报警吧，查询一个不存在的文件应该是这个正常场景
There was a problem hiding this comment.
这里提供的接口都是给上层的，比如qemu/nbd，挂在卷后，通过这个接口获取卷大小。所以这里正常不会出现文件不存在的情况。
| @@ -420,6 +434,8 @@ int FileClient::Listdir(const std::string& dirpath, | |||
| LIBCURVE_ERROR ret; | |||
| if (mdsClient_ != nullptr) { | |||
| ret = mdsClient_->Listdir(dirpath, userinfo, filestatVec); | |||
There was a problem hiding this comment.
同上，Listdir失败是否包含不存在的情况，不存在的情况下由于ERROR日志触发报警不合理
| @@ -442,6 +460,8 @@ int FileClient::Rmdir(const std::string& dirpath, const UserInfo_t& userinfo) { | |||
| LIBCURVE_ERROR ret; | |||
| if (mdsClient_ != nullptr) { | |||
| ret = mdsClient_->DeleteFile(dirpath, userinfo); | |||
| LOG_IF(ERROR, ret != LIBCURVE_ERROR::OK) | |||
There was a problem hiding this comment.
Delete是否幂等，返回notexist之类的是否需要打error
There was a problem hiding this comment.
这里就涉及到幂等的问题了。即使这里不打印error，还是会返回给上层用户文件/目录已经被删除了。
| @@ -178,7 +178,7 @@ bool Splitor::AssignInternal(IOTracker* iotracker, | |||
| (off_t)chunkidx * fileinfo->chunksize, | |||
| fileinfo, | |||
| &segInfo); | |||
| if (re == LIBCURVE_ERROR::FAILED || re == LIBCURVE_ERROR::AUTHFAIL) { | |||
| if (re != LIBCURVE_ERROR::OK) { | |||
There was a problem hiding this comment.
如果是not exist 是否不需要报error而触发报警
There was a problem hiding this comment.
这里的标志位true，所以不会返回not exist
| @@ -1163,7 +1163,7 @@ LIBCURVE_ERROR MDSClient::ListChunkServerInServer( | |||
| } | |||
|
|
|||
| int statusCode = response.statuscode(); | |||
| LOG_IF(ERROR, statusCode != 0) | |||
| LOG_IF(WARNING, statusCode != 0) | |||
There was a problem hiding this comment.
mds client一侧只是与mds交互的逻辑，所以这里不需要对异常状态进行报错。
具体的报错应该由调用方根据返回的状态进行处理。
wu-hanqing
force-pushed
the
change-log-level
branch
from
44f6f62
to
6dfe59f
Compare
wu-hanqing
force-pushed
the
change-log-level
branch
from
6dfe59f
to
9fcdde9
Compare
What problem does this PR solve?
Problem Summary: Change some client log level
Check List