-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax numpy version requirements #30
Conversation
I agree that current implementation is not very good. See my comment in issue #29 how this should be implemented. |
FYI the Travis failure related to test dependencies on the Ubuntu container has been fixed in f5b3562. |
Thanks. I've cherry picked it across. |
Note the numpy requirement in
For Appveyor I suggest to define a variable which contains the exact numpy version requirement for each build in the matrix and add a new install line for it, e.g. |
Ah right, thanks! |
This installs numpy, which now comes from travis.yml
I'm finished here. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Couple of small additions:
- Appveyor.yml: NP_VERSION can be 1.11.1 for all other Python versions except for 3.6 it should be 1.11.3.
- .travis.yml: Add also TEST_DEPENDS=numpy==1.11.3 for py36 builds in the matrix to make the test dependency consistent with the build dependency.
For Pythons that aren't 3.6
Do you want to clean up the commits before the merge? |
Yeah, let me do that. |
Hmm, I think it's easiest if I do the squashing directly from Github UI unless you want to do it manually with git. |
That works for me 👍 |
Thanks! |
Thanks for all the help! |
Just want to see if tests pass with this