refactoring catching all exceptions as const ref #12878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alalek are the CV_TRY and CV_CATCH macros still necessary or should their use disappear slowly from the codebase? |
This reverts commit 7349b8f (partially).
alalek
approved these changes
Nov 9, 2018
|
Thanks @alalek for merging and doing the work on CV_TRY |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates #12858
This pullrequest changes
refactored codebase such that exception handling is always using const ref
Now the codebase should be the same everywhere, except the files in 3rdparty. I didnt know if im allowed to touch them.