Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add javascript bindings for calib3d module. #14305

Merged
merged 1 commit into from
Jun 22, 2019
Merged

Add javascript bindings for calib3d module. #14305

merged 1 commit into from
Jun 22, 2019

Conversation

cameron-martin
Copy link
Contributor

@cameron-martin cameron-martin commented Apr 11, 2019 •
edited by alalek
Loading

resolves #14293

This pullrequest changes

This adds javascript bindings for the calib3d module, along with tests.

Currently I have only added the findHomography function, but will add the rest of the module soon.

force_builders_only=Docs,Custom
build_image:Docs=docs-js
build_image:Custom=javascript
buildworker:Custom=linux-4

alalek
alalek reviewed Apr 12, 2019
View reviewed changes
modules/js/src/helpers.js Outdated Show resolved Hide resolved
@dkurt dkurt marked this pull request as ready for review June 20, 2019 23:11
@dkurt
Copy link
Member

dkurt commented Jun 20, 2019

Hi! I rebased this PR with the latest master branch.

@cameron-martin
js: Add findHomography js bindings.
0ae053f 
Removed constants from legacy C api and switched out header with shorter version.

Removed blank line that was failing CI.
dkurt
dkurt approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@dkurt dkurt self-assigned this Jun 22, 2019
@opencv-pushbot opencv-pushbot merged commit 0ae053f into opencv:3.4 Jun 22, 2019
opencv-pushbot pushed a commit that referenced this pull request Jun 22, 2019
@alalek
Merge pull request #14305 from cameron-martin:calib3d-js
e72f451
@alalek alalek mentioned this pull request Jun 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek left review comments

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels
category: javascript (js) feature
Projects
None yet
Milestone
3.4.7
Development

Successfully merging this pull request may close these issues.
4 participants
@cameron-martin @dkurt @alalek @opencv-pushbot