Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve compatibility for qt 6. #19995

Closed
wants to merge 1 commit into from
Closed

Conversation

xhawk18
Copy link
Contributor

@xhawk18 xhawk18 commented Apr 28, 2021

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=linux,docs,Custom
build_image:Custom=qt:16.04
buildworker:Custom=linux-1

@vpisarev vpisarev self-assigned this May 26, 2021
@vpisarev vpisarev self-requested a review May 26, 2021 04:00
@vpisarev
Copy link
Contributor

@xhawk18, can you please re-submit the pull request from another branch? no need to close this PR, just create a dedicated branch, derived from fresh 3.4, and put your changes there. Currently we have a merge conflict, and because PR is submitted from 3.4 branch, the patch is not tested automatically.

@xhawk18 xhawk18 mentioned this pull request May 30, 2021
6 tasks
@asmorkalov
Copy link
Contributor

@xhawk18 Friendly reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants