-
-
Notifications
You must be signed in to change notification settings - Fork 55.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[G-API] Extend compileStreaming to support different overloads #20555
Merged
alalek
merged 6 commits into
opencv:master
from
TolyaTalamanov:at/fix-compileStreaming-bug
Aug 24, 2021
Merged
[G-API] Extend compileStreaming to support different overloads #20555
alalek
merged 6 commits into
opencv:master
from
TolyaTalamanov:at/fix-compileStreaming-bug
Aug 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TolyaTalamanov
commented
Aug 16, 2021
@mpashchenkov Could you have a look, please ? |
6 tasks
OrestChura
reviewed
Aug 20, 2021
dmatveev
approved these changes
Aug 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please address comments by @OrestChura
* Use macros for pyopencv_to GMetaArgs * Use GAPI_PROP_RW * Not split Prims python stuff
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…eaming-bug [G-API] Extend compileStreaming to support different overloads * Make different overloads * Order python compileStreaming overloads * Fix compileStreaming bug * Replace gin -> descr_of * Set error message * Fix review comments * Use macros for pyopencv_to GMetaArgs * Use GAPI_PROP_RW * Not split Prims python stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Overview
The goal of this PR is to support all different overloads for
compileStreaming
method in python, such as:To wrap these methods need to add
GAPI_WRAP
macros before every signature. The generated code will try every overloads in order from top to bottom as declared in c++ file and if overload isn't suitable (pyopencv_to
for params return false) try the next one. So the problem was thatpyopencv_to(cv::ExtractMetaCallback)
always returntrue
which means that thecompileStreaming(cv::ExtractMetaCallback, cv::GCompileArgs = { })
is always suitable.So the possible solution for that problem is put this overload in the end in that case it will be chosen only if others aren't suitable.
queue_capacity
compile arg in order to test overloads.pyopencv_to(cv::GMetaArg)
in order to wrapcompileStreaming(cv::GMetaArgs, cv::GCompileArgs)
Build configuration